Make RPC call synchronous in Fabric Sync #34187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin and
jepenven-silabs
pullapprove
bot
requested review from
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
|
PR #34187: Size comparison from 5e37260 to 8b7f10d Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tcarmelveilleux
requested changes
Jul 4, 2024
There was a problem hiding this comment.
- Busy waiting on shared data is guaranteed to be racy
- Instead, replace the RPC operations to be "starts" of operations which can be polled by a status RPC by the caller, for example. Alternatively, consider using event loop posting design with a separate worker to have a way to broker synchronization.
andy31415
reviewed
Jul 5, 2024
Please describe what operations need to be done in what order. |
I want to make all RPC call synchronous, so that I don't have to maintain a state machine that has transitions at specific events. Updated the PR, the WaitForResponse function uses a condition variable to wait for the response or timeout. The response completion callbacks (OnAddDeviceResponseCompleted and OnRemoveDeviceResponseCompleted) set the response flags and notify the waiting thread. This avoids busy waiting and makes the code more efficient and responsive. |
|
PR #34187: Size comparison from 8ebe19d to 8c4f13a Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tcarmelveilleux
approved these changes
Jul 10, 2024
tehampson
reviewed
Jul 11, 2024
joonhaengHeo
approved these changes
Jul 12, 2024
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 15, 2024
* Make RPC call synchronous in Fabric Sync * Address review comments
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 18, 2024
* Make RPC call synchronous in Fabric Sync * Address review comments
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Aug 14, 2024
* Make RPC call synchronous in Fabric Sync * Address review comments
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Sep 16, 2024
* Make RPC call synchronous in Fabric Sync * Address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to make all RPC call synchronous in Fabric Sync to grantee the correct sequence of Fabric Sync.
I have explored all possible options to make an RPC call synchronous but found that busy-waiting is the most reliable option so far.
A better option would be to use the pw client synchronous call wrappers, but they are quite expensive and not available in the current nanopb integration in the CHIP project.
Fixes #33784