-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Created possible fix for issue #229: Remove PICS from python PWRTL tests #34094
base: master
Are you sure you want to change the base?
[Fix] Created possible fix for issue #229: Remove PICS from python PWRTL tests #34094
Conversation
j-ororke
commented
Jun 27, 2024
- Removed PICS if statements from python TC_PWRTL_2_1 test module
- Used read_single_attribute_check_success() to get attribute ID's for available and active endpoints then compared attribute ID's with attribute list to verify DUT's supports those attributes.
- Updated if statement checks as possible that empty lists might also be equivalent to NullValue when checking active and available endpoints on DUT's
- Removed PICS if statements from TC_PWRTL_2_1 test module - Added if statements to check if attribute ID's for available and active endpoints gathered from DUT's are contained in attribute list - Updated method from NullValue to also include checking for empty lists from DUT's for available and active endpoints
PR #34094: Size comparison from 2908685 to 026828d Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
- Added else condition to return for cases where active or available attribute ID's were not in attibute list on DUT
PR #34094: Size comparison from 2908685 to 80faf03 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #34094: Size comparison from d033f8b to 5fa7466 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
- Replaced method for setting endpoint variable - Removed null check for available endpoints in test step 2. - Reworded verbiage for skipping test step 3 if condition is not met.
PR #34094: Size comparison from cbd15a1 to 22448f1 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
- Fixed found linting errors
- Resolved new found linting errors.
PR #34094: Size comparison from cbd15a1 to 0e73e12 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Co-authored-by: C Freeman <[email protected]>
Co-authored-by: C Freeman <[email protected]>
PR #34094: Size comparison from 83159c2 to 13cc798 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #34094: Size comparison from e814987 to 22f650d Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #34094: Size comparison from 86a5270 to ba96dbb Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|