Feature/enhanced setup flow feature #34065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran and
hawk248
woody-apple
requested review from
hiroto-kanda,
xshuqun,
bzbarsky-apple,
koosc and
andy31415
andy31415
reviewed
Dec 14, 2024
andy31415
reviewed
Dec 14, 2024
andy31415
previously requested changes
Dec 14, 2024
andy31415
reviewed
Dec 14, 2024
src/app/clusters/general-commissioning-server/general-commissioning-server.cpp
Outdated
Show resolved
Hide resolved
andy31415
reviewed
Dec 14, 2024
- Moved the configuration from core into app buildconfig - renamed the flag to expand `TC` into `TERMS AND CONDITIONS` - updated includes in general-commissioning to include the right header - added the configuration as a build option into targets.py/host.py - updated unit test
- Create a separate source set for terms and conditions - include the manager cpp in that file - make the build conditional (this required flag moving) - fixed typo in targets.py to make things compile Compile-tested only (the -terms-and-conditions variant of all clusters compiled)
andy31415
dismissed
their stale review
I updated the code to have cpp compiled in and build-tested the new build flag.
|
PR #34065: Size comparison from cfdaf79 to 813c8e9 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Dec 16, 2024
src/app/clusters/general-commissioning-server/general-commissioning-server.cpp
Show resolved
Hide resolved
|
PR #34065: Size comparison from cfdaf79 to 64df3b6 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate Terms and Conditions Acknowledgements in Commissioning Process
Fixes #34064
Add support for setting Terms and Conditions acknowledgements
acknowledgment version in the General Commissioning cluster.
acknowledgements.
Enhance setup flow handling
Conditions acknowledgements.
Conditions acknowledgements.
Handle setting Terms and Conditions acknowledgements
commissioning process.
Zap regen
Testing
src/app/tests/TestDefaultTermsAndConditionsProvider.cppwith about 70% coverage onDefaultTermsAndConditionsProvider.cpp(some error paths not covered)