Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compile crash on glib compilation with glib dev install #34018

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Fix compile crash on glib compilation with glib dev install #34018

merged 2 commits into from
Jun 19, 2024

Conversation

andy31415
Copy link
Contributor

@andy31415 andy31415 commented Jun 19, 2024 •
edited
Loading

After #34016 compiling glib separately with thread sanitizers seems to crash. Moved the install of the dev library to after the glib compile.

Tested

chip-build image now builds.

@andy31415 andy31415 added the hotfix urgent fix needed, can bypass review label Jun 19, 2024
@andy31415 andy31415 merged commit 3b4371e into project-chip:master Jun 19, 2024
65 of 66 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 19, 2024 •
edited
Loading

PR #34018: Size comparison from 1ae130f to 1758a60

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 1ae130f 1758a60 change % change
bl602 lighting-app bl602 FLASH 1270534 1270534 0 0.0
RAM 95328 95328 0 0.0
bl602+mfd FLASH 1284812 1284812 0 0.0
RAM 95480 95480 0 0.0
bl602+rpc FLASH 1309734 1309734 0 0.0
RAM 103760 103760 0 0.0
bl702 lighting-app bl702 FLASH 1091430 1091430 0 0.0
RAM 14897 14897 0 0.0
bl702+mfd FLASH 1102124 1102124 0 0.0
RAM 15049 15049 0 0.0
bl702+rpc FLASH 1181240 1181240 0 0.0
RAM 23925 23925 0 0.0
bl706-eth FLASH 874774 874774 0 0.0
RAM 27016 27016 0 0.0
bl706-wifi FLASH 1127068 1127068 0 0.0
RAM 14349 14349 0 0.0
bl702l lighting-app bl702l FLASH 1078316 1078316 0 0.0
RAM 21468 21468 0 0.0
bl702l+mfd FLASH 1089578 1089578 0 0.0
RAM 21628 21628 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 798100 798100 0 0.0
RAM 103088 103088 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 813752 813752 0 0.0
RAM 113568 113568 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 803276 803276 0 0.0
RAM 107688 107688 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 756052 756052 0 0.0
RAM 101788 101788 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 741724 741724 0 0.0
RAM 102036 102036 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 605750 605750 0 0.0
RAM 204512 204512 0 0.0
lock CC3235SF_LAUNCHXL FLASH 650770 650770 0 0.0
RAM 204772 204772 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 661681 661681 0 0.0
RAM 74512 74512 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 681525 681525 0 0.0
RAM 77144 77144 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 681525 681525 0 0.0
RAM 77144 77144 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 638469 638469 0 0.0
RAM 69580 69580 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 604137 604137 0 0.0
RAM 70216 70216 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 623781 623781 0 0.0
RAM 72768 72768 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 623781 623781 0 0.0
RAM 72768 72768 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 619633 619633 0 0.0
RAM 73232 73232 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 639349 639349 0 0.0
RAM 75784 75784 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 639349 639349 0 0.0
RAM 75784 75784 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 588213 588213 0 0.0
RAM 67200 67200 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 608073 608073 0 0.0
RAM 69832 69832 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 608073 608073 0 0.0
RAM 69832 69832 0 0.0
efr32 lighting-app BRD4187C FLASH 888232 888224 -8 -0.0
RAM 183424 183424 0 0.0
lock-app BRD4338a FLASH 699848 699848 0 0.0
RAM 242228 242228 0 0.0
window-app BRD4187C FLASH 969748 969748 0 0.0
RAM 167856 167856 0 0.0
esp32 all-clusters-app c3devkit DRAM 88324 88324 0 0.0
FLASH 1468934 1468934 0 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 114796 114796 0 0.0
FLASH 1538059 1538059 0 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4568 4568 0 0.0
FLASH 2516608 2516608 0 0.0
RAM 123760 123760 0 0.0
all-clusters-app debug unknown 5344 5344 0 0.0
FLASH 5565742 5565742 0 0.0
RAM 477960 477960 0 0.0
all-clusters-minimal-app debug unknown 5264 5264 0 0.0
FLASH 5039112 5039112 0 0.0
RAM 231512 231512 0 0.0
bridge-app debug unknown 5232 5232 0 0.0
FLASH 4464792 4464792 0 0.0
RAM 211424 211424 0 0.0
chip-tool debug unknown 5720 5720 0 0.0
FLASH 11539575 11539575 0 0.0
RAM 530138 530138 0 0.0
chip-tool-ipv6only arm64 unknown 19816 19816 0 0.0
FLASH 10671364 10671364 0 0.0
RAM 578928 578928 0 0.0
fabric-admin debug unknown 5576 5576 0 0.0
FLASH 10538503 10538503 0 0.0
RAM 524154 524154 0 0.0
fabric-bridge-app debug unknown 5240 5240 0 0.0
FLASH 4335368 4335368 0 0.0
RAM 203552 203552 0 0.0
lighting-app debug+rpc+ui unknown 5880 5880 0 0.0
FLASH 5361122 5361122 0 0.0
RAM 220328 220328 0 0.0
lock-app debug unknown 5168 5168 0 0.0
FLASH 4528424 4528424 0 0.0
RAM 198880 198880 0 0.0
ota-provider-app debug unknown 4552 4552 0 0.0
FLASH 4184200 4184200 0 0.0
RAM 193216 193216 0 0.0
ota-requestor-app debug unknown 4488 4488 0 0.0
FLASH 4309688 4309688 0 0.0
RAM 197872 197872 0 0.0
shell debug unknown 4104 4104 0 0.0
FLASH 2784029 2784029 0 0.0
RAM 149104 149104 0 0.0
thermostat-no-ble arm64 unknown 9184 9184 0 0.0
FLASH 4154964 4154964 0 0.0
RAM 234608 234608 0 0.0
tv-app debug unknown 5456 5456 0 0.0
FLASH 5582024 5582024 0 0.0
RAM 340360 340360 0 0.0
tv-casting-app debug unknown 5080 5080 0 0.0
FLASH 9584582 9584582 0 0.0
RAM 347504 347504 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1497404 1497404 0 0.0
RAM 226072 226072 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 876212 876212 0 0.0
RAM 139129 139129 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 949244 949244 0 0.0
RAM 137557 137557 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 822412 822412 0 0.0
RAM 138027 138027 0 0.0
nxp contact k32w0+release FLASH 575604 575604 0 0.0
RAM 70024 70024 0 0.0
k32w1+release FLASH 590728 590728 0 0.0
RAM 74056 74056 0 0.0
light k32w0+release FLASH 609680 609680 0 0.0
RAM 69500 69500 0 0.0
k32w1+release FLASH 674232 674232 0 0.0
RAM 82808 82808 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1613444 1613444 0 0.0
RAM 207132 207132 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1534228 1534228 0 0.0
RAM 204036 204036 0 0.0
light cy8ckit_062s2_43012 FLASH 1461092 1461092 0 0.0
RAM 197316 197316 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462844 1462844 0 0.0
RAM 224380 224380 0 0.0
qpg lighting-app qpg6105+debug FLASH 650600 650600 0 0.0
RAM 104556 104556 0 0.0
lock-app qpg6105+debug FLASH 610700 610700 0 0.0
RAM 99232 99232 0 0.0
stm32 light STM32WB5MM-DK FLASH 472136 472136 0 0.0
RAM 141652 141652 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 625548 625548 0 0.0
RAM 49904 49904 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 602588 602588 0 0.0
RAM 130288 130288 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 770710 770710 0 0.0
RAM 110052 110052 0 0.0
bridge-app tlsr9258a FLASH 668634 668634 0 0.0
RAM 94672 94672 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 627270 627270 0 0.0
RAM 49948 49948 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 713384 713384 0 0.0
RAM 76540 76540 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 558256 558256 0 0.0
RAM 126544 126544 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 793336 793336 0 0.0
RAM 99900 99900 0 0.0
lock-app-dfu tlsr9528a FLASH 660372 660372 0 0.0
RAM 69228 69228 0 0.0
ota-requestor-app tlsr9258a FLASH 687252 687252 0 0.0
RAM 94396 94396 0 0.0
pump-app tlsr9518adk80d FLASH 609490 609490 0 0.0
RAM 56328 56328 0 0.0
pump-controller-app tlsr9518adk80d FLASH 599876 599876 0 0.0
RAM 56128 56128 0 0.0
shell tlsr9518adk80d FLASH 462614 462614 0 0.0
RAM 71852 71852 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 633632 633632 0 0.0
RAM 51576 51576 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 642990 642990 0 0.0
RAM 59764 59764 0 0.0
thermostat tlsr9518adk80d FLASH 618766 618766 0 0.0
RAM 56452 56452 0 0.0
window-covering tlsr9118bdk40d FLASH 464958 464958 0 0.0
RAM 82224 82224 0 0.0
tizen all-clusters-app arm unknown 1548 1548 0 0.0
FLASH 1624084 1624084 0 0.0
RAM 45420 45420 0 0.0
chip-tool-ubsan arm unknown 2360 2360 0 0.0
FLASH 15867254 15867254 0 0.0
RAM 6966668 6966668 0 0.0

austina-csa pushed a commit to austina-csa/connectedhomeip that referenced this pull request Jul 10, 2024
@andy31415 @andreilitvin @austina-csa
Fix compile crash on glib compilation with glib dev install (project-…
9ffbebf 
…chip#34018)

* Fix compile crash on glib compilation with glib dev install

* Restyle

---------

Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docker hotfix urgent fix needed, can bypass review integrations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andy31415 @andreilitvin