-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux: link with libatomic #33628
Linux: link with libatomic #33628
Conversation
PR #33628: Size comparison from 16d6475 to 76c2355 Increases above 0.2%:
Increases (2 builds for linux)
Decreases (3 builds for efr32)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
It seems that Tizen QEMU image lacks libatomic.so file. If you want I can add it to the image, but that will require Docker image update (so it will take some time). EDIT: |
Merged that PR and am updating images now. |
76c2355
to
07ebbd2
Compare
PR #33628: Size comparison from a98dc79 to 07ebbd2 Increases above 0.2%:
Increases (2 builds for linux)
Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
07ebbd2
to
3c08c9c
Compare
PR #33628: Size comparison from 47ab39e to 3c08c9c Increases above 0.2%:
Increases (2 builds for linux)
Decreases (1 build for linux)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
Tizen still fails with:
Strange.... I've tested that locally yesterday and everything was fine with updated Docker QEMU image. Unfortunately, I'm off computer until Monday, so I'm not able to check whether the Docker image was properly created... |
:D That's way it's better to update ALL images at once! |
Hm yeah I guess I can do all of them instead |
And specifically pick up new Tizen build container for qemu for project-chip#33628
And specifically pick up new Tizen build container for qemu for #33628
Use of atomic builtins (__atomic_*) can require -latomic depending on what gets inlined (or not) on a particular platform.
3c08c9c
to
4704aba
Compare
PR #33628: Size comparison from 2aeb939 to 4704aba Increases above 0.2%:
Increases (2 builds for linux)
Decreases (1 build for linux)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
…3669) And specifically pick up new Tizen build container for qemu for project-chip#33628
Use of atomic builtins (__atomic_*) can require -latomic depending on what gets inlined (or not) on a particular platform.
…3669) And specifically pick up new Tizen build container for qemu for project-chip#33628
Use of atomic builtins (
__atomic_*
) can require-latomic
depending on what gets inlined (or not) on a particular platform.For example