-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metrics] Metrics in core commissioning phase #33247
Merged
mergify
merged 6 commits into
project-chip:master
from
anush-apple:metrics-commissioning
May 17, 2024
Merged
[Metrics] Metrics in core commissioning phase #33247
mergify
merged 6 commits into
project-chip:master
from
anush-apple:metrics-commissioning
May 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
anush-apple
commented
Apr 30, 2024
- Added metrics tracing in core parts of the commissionning flow:
- PASE
- OperationalSessionSetup
- Different stages of commissioning
pullapprove
bot
requested review from
andy31415,
andyg-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple and
lazarkov
April 30, 2024 22:44
pullapprove
bot
requested review from
woody-apple,
younghak-hwang and
yunhanw-google
April 30, 2024 22:44
PR #33247: Size comparison from 335ae19 to 50a292d Increases above 0.2%:
Increases (14 builds for linux)
Decreases (3 builds for efr32, linux)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
- Added metrics tracing in core parts of the commissionning flow: - PASE - OperationalSessionSetup - Different stages of commissioning
anush-apple
force-pushed
the
metrics-commissioning
branch
from
May 14, 2024 23:12
5bb6889
to
67c629e
Compare
PR #33247: Size comparison from c7f7984 to 67c629e Increases above 0.2%:
Increases (15 builds for linux)
Decreases (4 builds for efr32, linux)
Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
Co-authored-by: Boris Zbarsky <[email protected]>
bzbarsky-apple
approved these changes
May 16, 2024
tcarmelveilleux
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.