Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some better logging around PASE session setup in Matter.framework. #33231

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Add some better logging around PASE session setup in Matter.framework. #33231

merged 1 commit into from
Apr 30, 2024

Conversation

bzbarsky-apple
Copy link
Contributor

Log the device ID being used.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 29, 2024 •
edited
Loading

PR #33231: Size comparison from 9db03ee to 076605a

Decreases (1 build for efr32)
platform target config section 9db03ee 076605a change % change
efr32 lighting-app BRD4187C (read/write) 1069984 1069976 -8 -0.0
.text 886556 886548 -8 -0.0
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
platform target config section 9db03ee 076605a change % change
bl602 lighting-app bl602 (read/write) 1444226 1444226 0 0.0
.bss 85720 85720 0 0.0
.data 9512 9512 0 0.0
.rodata 159220 159220 0 0.0
.text 1109116 1109116 0 0.0
bl602+mfd (read/write) 1458650 1458650 0 0.0
.bss 85888 85888 0 0.0
.data 9488 9488 0 0.0
.rodata 158180 158180 0 0.0
.text 1124434 1124434 0 0.0
bl602+rpc (read/write) 1491618 1491618 0 0.0
.bss 93760 93760 0 0.0
.data 9888 9888 0 0.0
.rodata 166788 166788 0 0.0
.text 1140506 1140506 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1209543 1209543 0 0.0
.bss 11185 11185 0 0.0
.data 3704 3704 0 0.0
.rodata 108816 108816 0 0.0
.text 978874 978874 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1220635 1220635 0 0.0
.bss 11361 11361 0 0.0
.data 3688 3688 0 0.0
.rodata 107756 107756 0 0.0
.text 990884 990884 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1301287 1301287 0 0.0
.bss 19669 19669 0 0.0
.data 4248 4248 0 0.0
.rodata 124188 124188 0 0.0
.text 1053838 1053838 0 0.0
bl706-eth (read/write) 1026313 1026313 0 0.0
.bss 23760 23760 0 0.0
.data 3256 3256 0 0.0
.rodata 101904 101904 0 0.0
.text 769088 769088 0 0.0
bl706-wifi (read/write) 1261482 1261482 0 0.0
.bss 10645 10645 0 0.0
.data 3704 3704 0 0.0
.rodata 122904 122904 0 0.0
.text 1001488 1001488 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1179136 1179136 0 0.0
.bss 16396 16396 0 0.0
.data 5072 5072 0 0.0
.rodata 102820 102820 0 0.0
.text 971984 971984 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1190280 1190280 0 0.0
.bss 16572 16572 0 0.0
.data 5048 5048 0 0.0
.rodata 101760 101760 0 0.0
.text 984050 984050 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 784252 784252 0 0.0
(read/write) 176660 176660 0 0.0
.bss 98604 98604 0 0.0
.data 3588 3588 0 0.0
.rodata 83092 83092 0 0.0
.text 700896 700896 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 800052 800052 0 0.0
(read/write) 187148 187148 0 0.0
.bss 109092 109092 0 0.0
.data 3588 3588 0 0.0
.rodata 77084 77084 0 0.0
.text 722700 722700 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 788820 788820 0 0.0
(read/write) 181268 181268 0 0.0
.bss 103212 103212 0 0.0
.data 3588 3588 0 0.0
.rodata 103996 103996 0 0.0
.text 684560 684560 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 741212 741212 0 0.0
(read/write) 175636 175636 0 0.0
.bss 97344 97344 0 0.0
.data 3580 3580 0 0.0
.rodata 78756 78756 0 0.0
.text 662192 662192 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 726876 726876 0 0.0
(read/write) 175844 175844 0 0.0
.bss 97568 97568 0 0.0
.data 3572 3572 0 0.0
.rodata 74540 74540 0 0.0
.text 652072 652072 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 589022 589022 0 0.0
(read/write) 208372 208372 0 0.0
.bss 201596 201596 0 0.0
.data 1652 1652 0 0.0
.rodata 87654 87654 0 0.0
.text 499248 499248 0 0.0
lock CC3235SF_LAUNCHXL (read only) 634870 634870 0 0.0
(read/write) 208636 208636 0 0.0
.bss 202000 202000 0 0.0
.data 1516 1516 0 0.0
.rodata 108414 108414 0 0.0
.text 524332 524332 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 570959 570959 0 0.0
.app_xip_area 460869 460869 0 0.0
.bss 64908 64908 0 0.0
.data 760 760 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 553047 553047 0 0.0
.app_xip_area 438285 438285 0 0.0
.bss 69572 69572 0 0.0
.data 768 768 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 573719 573719 0 0.0
.app_xip_area 465125 465125 0 0.0
.bss 63452 63452 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 566159 566159 0 0.0
.app_xip_area 454381 454381 0 0.0
.bss 66556 66556 0 0.0
.data 800 800 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4187C (read/write) 1069984 1069976 -8 -0.0
.bss 179976 179976 0 0.0
.data 3432 3432 0 0.0
.text 886556 886548 -8 -0.0
lock-app BRD4338a (read/write) 964324 964324 0 0.0
.bss 210528 210528 0 0.0
.data 30288 30288 0 0.0
.text 704144 704144 0 0.0
window-app BRD4187C (read/write) 1137004 1137004 0 0.0
.bss 164568 164568 0 0.0
.data 3336 3336 0 0.0
.text 969080 969080 0 0.0
esp32 all-clusters-app c3devkit (read only) 1214856 1214856 0 0.0
(read/write) 1751288 1751288 0 0.0
.dram0.bss 74568 74568 0 0.0
.dram0.data 13652 13652 0 0.0
.flash.rodata 253528 253528 0 0.0
.flash.text 1214856 1214856 0 0.0
.iram0.text 75570 75570 0 0.0
m5stack (read only) 1256607 1256607 0 0.0
(read/write) 537684 537684 0 0.0
.dram0.bss 81320 81320 0 0.0
.dram0.data 35196 35196 0 0.0
.flash.rodata 285248 285248 0 0.0
.flash.text 1250443 1250443 0 0.0
.iram0.text 125403 125403 0 0.0
linux air-purifier-app debug (read only) 2656837 2656837 0 0.0
(read/write) 130384 130384 0 0.0
.bss 47016 47016 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 75160 75160 0 0.0
.dynamic 608 608 0 0.0
.got 4520 4520 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 184464 184464 0 0.0
.text 2293093 2293093 0 0.0
all-clusters-app debug (read only) 5970089 5970089 0 0.0
(read/write) 481992 481992 0 0.0
.bss 135296 135296 0 0.0
.data 4560 4560 0 0.0
.data.rel.ro 334712 334712 0 0.0
.dynamic 624 624 0 0.0
.got 5328 5328 0 0.0
.init 27 27 0 0.0
.init_array 1440 1440 0 0.0
.rodata 350832 350832 0 0.0
.text 5183827 5183827 0 0.0
all-clusters-minimal-app debug (read only) 5254081 5254081 0 0.0
(read/write) 238008 238008 0 0.0
.bss 128160 128160 0 0.0
.data 4464 4464 0 0.0
.data.rel.ro 98296 98296 0 0.0
.dynamic 624 624 0 0.0
.got 5248 5248 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 290058 290058 0 0.0
.text 4727251 4727251 0 0.0
bridge-app debug (read only) 4644665 4644665 0 0.0
(read/write) 218888 218888 0 0.0
.bss 118688 118688 0 0.0
.data 6240 6240 0 0.0
.data.rel.ro 87248 87248 0 0.0
.dynamic 624 624 0 0.0
.got 5216 5216 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 230474 230474 0 0.0
.text 4191843 4191843 0 0.0
chip-tool debug (read only) 12112897 12112897 0 0.0
(read/write) 523456 523456 0 0.0
.bss 95032 95032 0 0.0
.data 5122 5122 0 0.0
.data.rel.ro 416064 416064 0 0.0
.dynamic 624 624 0 0.0
.got 5736 5736 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 451577 451577 0 0.0
.text 10952723 10952723 0 0.0
chip-tool-ipv6only arm64 (read only) 11443476 11443476 0 0.0
(read/write) 589016 589016 0 0.0
.bss 104008 104008 0 0.0
.data 4520 4520 0 0.0
.data.rel.ro 456016 456016 0 0.0
.dynamic 512 512 0 0.0
.got 17104 17104 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 356340 356340 0 0.0
.text 10205240 10205240 0 0.0
lighting-app debug+rpc+ui (read only) 5567817 5567817 0 0.0
(read/write) 227656 227656 0 0.0
.bss 119632 119632 0 0.0
.data 4896 4896 0 0.0
.data.rel.ro 95616 95616 0 0.0
.dynamic 672 672 0 0.0
.got 5856 5856 0 0.0
.init 27 27 0 0.0
.init_array 976 976 0 0.0
.rodata 354292 354292 0 0.0
.text 4964787 4964787 0 0.0
lock-app debug (read only) 4711937 4711937 0 0.0
(read/write) 206112 206112 0 0.0
.bss 113960 113960 0 0.0
.data 4192 4192 0 0.0
.data.rel.ro 81256 81256 0 0.0
.dynamic 624 624 0 0.0
.got 5168 5168 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 256394 256394 0 0.0
.text 4242259 4242259 0 0.0
ota-provider-app debug (read only) 4319633 4319633 0 0.0
(read/write) 194616 194616 0 0.0
.bss 113760 113760 0 0.0
.data 4368 4368 0 0.0
.data.rel.ro 70544 70544 0 0.0
.dynamic 624 624 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 209290 209290 0 0.0
.text 3915571 3915571 0 0.0
ota-requestor-app debug (read only) 4450209 4450209 0 0.0
(read/write) 198984 198984 0 0.0
.bss 114656 114656 0 0.0
.data 4768 4768 0 0.0
.data.rel.ro 73648 73648 0 0.0
.dynamic 624 624 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 215338 215338 0 0.0
.text 4035555 4035555 0 0.0
shell debug (read only) 2941369 2941369 0 0.0
(read/write) 157424 157424 0 0.0
.bss 62800 62800 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 87400 87400 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 1112 1112 0 0.0
.rodata 187744 187744 0 0.0
.text 2578226 2578226 0 0.0
thermostat-no-ble arm64 (read only) 4443628 4443628 0 0.0
(read/write) 244360 244360 0 0.0
.bss 122264 122264 0 0.0
.data 3408 3408 0 0.0
.data.rel.ro 104520 104520 0 0.0
.dynamic 512 512 0 0.0
.got 8720 8720 0 0.0
.init 24 24 0 0.0
.init_array 448 448 0 0.0
.rodata 160436 160436 0 0.0
.text 3946072 3946072 0 0.0
tv-app debug (read only) 5788417 5788417 0 0.0
(read/write) 353816 353816 0 0.0
.bss 244528 244528 0 0.0
.data 6560 6560 0 0.0
.data.rel.ro 95432 95432 0 0.0
.dynamic 624 624 0 0.0
.got 5464 5464 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 295274 295274 0 0.0
.text 5249075 5249075 0 0.0
tv-casting-app debug (read only) 9929425 9929425 0 0.0
(read/write) 343616 343616 0 0.0
.bss 158744 158744 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 174960 174960 0 0.0
.dynamic 624 624 0 0.0
.got 5040 5040 0 0.0
.init 27 27 0 0.0
.init_array 1216 1216 0 0.0
.rodata 384760 384760 0 0.0
.text 9077475 9077475 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2536248 2536248 0 0.0
.bss 220808 220808 0 0.0
.data 5216 5216 0 0.0
.text 1498932 1498932 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1059400 1059400 0 0.0
bss 139123 139123 0 0.0
rodata 101560 101560 0 0.0
text 771500 771500 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1236720 1236720 0 0.0
bss 137395 137395 0 0.0
rodata 151392 151392 0 0.0
text 797908 797908 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1007360 1007360 0 0.0
bss 138029 138029 0 0.0
rodata 88824 88824 0 0.0
text 733220 733220 0 0.0
nxp contact k32w0+release (read only) 576012 576012 0 0.0
(read/write) 83140 83140 0 0.0
.bss 67856 67856 0 0.0
.data 2188 2188 0 0.0
.text 575476 575476 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 703404 703404 0 0.0
.bss 71200 71200 0 0.0
.data 2864 2864 0 0.0
.text 589960 589960 0 0.0
light k32w0+release (read only) 610008 610008 0 0.0
(read/write) 82600 82600 0 0.0
.bss 67296 67296 0 0.0
.data 2208 2208 0 0.0
.text 609472 609472 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 795256 795256 0 0.0
.bss 80736 80736 0 0.0
.data 2064 2064 0 0.0
.text 673088 673088 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 832056 832056 0 0.0
(read/write) 1807452 1807452 0 0.0
.bss 198540 198540 0 0.0
.data 2744 2744 0 0.0
.text 1597780 1597780 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 835152 835152 0 0.0
(read/write) 1728900 1728900 0 0.0
.bss 195468 195468 0 0.0
.data 2720 2720 0 0.0
.text 1522324 1522324 0 0.0
light cy8ckit_062s2_43012 (read only) 841872 841872 0 0.0
(read/write) 1647532 1647532 0 0.0
.bss 188932 188932 0 0.0
.data 2536 2536 0 0.0
.text 1447676 1447676 0 0.0
lock cy8ckit_062s2_43012 (read only) 814808 814808 0 0.0
(read/write) 1676196 1676196 0 0.0
.bss 216012 216012 0 0.0
.data 2520 2520 0 0.0
.text 1449276 1449276 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1133588 1133588 0 0.0
.bss 102620 102620 0 0.0
.data 856 856 0 0.0
.text 645968 645968 0 0.0
lock-app qpg6105+debug (read/write) 1093412 1093412 0 0.0
.bss 97292 97292 0 0.0
.data 860 860 0 0.0
.text 605796 605796 0 0.0
stm32 light STM32WB5MM-DK (read/write) 605201 605201 0 0.0
.bss 128468 128468 0 0.0
.data 688 688 0 0.0
.rodata 80532 80532 0 0.0
.text 385768 385768 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 833794 833794 0 0.0
bss 49852 49852 0 0.0
text 624468 624468 0 0.0
all-clusters-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 1096072 1096072 0 0.0
bss 101520 101520 0 0.0
text 797082 797082 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1058588 1058588 0 0.0
bss 110016 110016 0 0.0
text 772444 772444 0 0.0
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 914284 914284 0 0.0
bss 92772 92772 0 0.0
text 656094 656094 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 836162 836162 0 0.0
bss 49896 49896 0 0.0
text 626900 626900 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 936912 936912 0 0.0
bss 77508 77508 0 0.0
text 703492 703492 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1090684 1090684 0 0.0
bss 99864 99864 0 0.0
text 794090 794090 0 0.0
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 911280 911280 0 0.0
bss 69176 69176 0 0.0
text 660302 660302 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 933080 933080 0 0.0
bss 92476 92476 0 0.0
text 675078 675078 0 0.0
pump-app tlsr9258a (read only) 52490 52490 0 0.0
(read/write) 833696 833696 0 0.0
bss 58140 58140 0 0.0
text 623878 623878 0 0.0
pump-controller-app tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 799808 799808 0 0.0
bss 56068 56068 0 0.0
text 598780 598780 0 0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 676236 676236 0 0.0
bss 73452 73452 0 0.0
text 461910 461910 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 843998 843998 0 0.0
bss 51524 51524 0 0.0
text 633544 633544 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 858673 858673 0 0.0
bss 59692 59692 0 0.0
text 642342 642342 0 0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 825380 825380 0 0.0
bss 56400 56400 0 0.0
text 618352 618352 0 0.0
window-covering tlsr9258a (read only) 52490 52490 0 0.0
(read/write) 838424 838424 0 0.0
bss 58356 58356 0 0.0
text 626178 626178 0 0.0

@pullapprove pullapprove bot requested a review from kiel-apple April 30, 2024 21:09
@mergify mergify bot merged commit 335ae19 into project-chip:master Apr 30, 2024
65 checks passed
@bzbarsky-apple bzbarsky-apple deleted the better-logging-commissioning-sessions branch April 30, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksperling-apple ksperling-apple ksperling-apple left review comments

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@dhrishi dhrishi Awaiting requested review from dhrishi

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

Assignees
No one assigned
Labels
darwin review - approved
Projects
[Platform] Darwin
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bzbarsky-apple @yunhanw-google @Damian-Nordic @ksperling-apple