-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix builds to macos-13 rather than latest due to bootstrap python incompatibilities #33142
Merged
andy31415
merged 1 commit into
project-chip:master
from
andy31415:fix-macos-runner-version
Apr 24, 2024
Merged
Fix builds to macos-13 rather than latest due to bootstrap python incompatibilities #33142
andy31415
merged 1 commit into
project-chip:master
from
andy31415:fix-macos-runner-version
Apr 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
April 24, 2024 14:44
pullapprove
bot
requested review from
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
April 24, 2024 14:44
andy31415
commented
Apr 24, 2024
PR #33142: Size comparison from e1dd279 to e8fbd23 Decreases (1 build for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
Marking as hotfix and will merge as without this entire CI is blocked on darwin and no PRs can be checked. @woody-apple @bzbarsky-apple @ksperling-apple please be aware and update with other fixes as appropriate for Darwin. For now I just patched it to unblock CI. |
andy31415
added a commit
to andy31415/connectedhomeip
that referenced
this pull request
Apr 25, 2024
andy31415
added a commit
to andy31415/connectedhomeip
that referenced
this pull request
Apr 25, 2024
andy31415
added a commit
to andy31415/connectedhomeip
that referenced
this pull request
May 3, 2024
andy31415
added a commit
that referenced
this pull request
May 3, 2024
* Fix builds to macos-13 rather than latest due to bootstrap python incompatibilities (#33142) * Fix google-api-core (#32687) * [ESP32] bump the component manager version (#32474) * [ESP32] bump the component manager version * Update requirements.esp32.txt * Update requirements.esp32.txt * fix the version in constraints.txt * Bump prompt-toolkit requirement to fix ptpython version update (#30987) * Undo protobuf constraint fixing - make requirements and constraints equal --------- Co-authored-by: Shubham Patil <[email protected]> Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds seem to fail with
AttributeError: cython_sources
which seems to point at an incompatibility between PyYaml and python 3.12 (pyyaml seems to claim compatibility up to python 3.11 so far)Preliminary investigation of failures seem to indicate:
macos-latest
was pointing tomacos-12
(odd, since 13 also existed)macos-14-arm64
we started having failuresSo this may be python version or architecture version or both.
Unclear if this is the correct fix since we presumably want to ensure darwin code compiles on the latest release of the platform, however for now validating the claim that runner version is at fault for build failures.