-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
30754 cicd dependabot ci runs for both push and pull effectively double the processing #32833
Merged
mergify
merged 33 commits into
project-chip:master
from
kliao-csa:30754-cicd-dependabot-ci-runs-for-both-push-and-pull-effectively-double-the-processing
Apr 9, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #32833: Size comparison from 978dfcb to 5448423 Full report (9 builds for cc32xx, mbed, nrfconnect, qpg, stm32)
|
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo and
chshu
April 3, 2024 20:37
vatsalghelani-csa
approved these changes
Apr 3, 2024
PR #32833: Size comparison from 978dfcb to d4a024a Decreases (2 builds for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
PR #32833: Size comparison from 978dfcb to 05d348b Increases above 0.2%:
Increases (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Decreases (23 builds for linux, psoc6, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
andy31415
approved these changes
Apr 8, 2024
Entire yaml seems to be deleted so I'm removing changes to the file
…h-and-pull-effectively-double-the-processing
PR #32833: Size comparison from f29ccbe to 4bf4deb Decreases (1 build for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
jmartinez-silabs
approved these changes
Apr 9, 2024
kliao-csa
deleted the
30754-cicd-dependabot-ci-runs-for-both-push-and-pull-effectively-double-the-processing
branch
April 9, 2024 22:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable CI runs for push on any branch except master. This means if we want CI runs on branches not from a fork of connectedhomeip, we will need to make pull requests. Dependabot already does this and I'm not aware of any process that doesn't, so this should be a good standard.
For #30754