-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added scripts to get metadata (runner arguments) associated with the python_testing scripts for automating the process #32752
Merged
andy31415
merged 95 commits into
project-chip:master
from
vatsalghelani-csa:feature/metadataParser
Apr 15, 2024
Merged
Added scripts to get metadata (runner arguments) associated with the python_testing scripts for automating the process #32752
andy31415
merged 95 commits into
project-chip:master
from
vatsalghelani-csa:feature/metadataParser
Apr 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #32752: Size comparison from b1f26f8 to ab74101 Full report (17 builds for cc13x4_26x4, esp32, k32w, nrfconnect, qpg, stm32)
|
andy31415
reviewed
Mar 27, 2024
andy31415
reviewed
Mar 27, 2024
PR #32752: Size comparison from b1f26f8 to 02316a7 Increases (18 builds for bl602, bl702, bl702l, cyw30739, mbed, nrfconnect, psoc6)
Decreases (1 build for bl702l)
Full report (22 builds for bl602, bl702, bl702l, cyw30739, mbed, nrfconnect, psoc6)
|
andy31415
reviewed
Mar 27, 2024
Just keeping the runner arguments required for testing purpose and removing all the unwanted test script code for this current testing use case
PR #32752: Size comparison from b1f26f8 to 58acf15 Increases (22 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, esp32, psoc6)
Decreases (1 build for bl702l)
Full report (25 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, esp32, psoc6)
|
pullapprove
bot
requested review from
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
April 8, 2024 16:18
andy31415
reviewed
Apr 11, 2024
andy31415
reviewed
Apr 11, 2024
andy31415
reviewed
Apr 15, 2024
andy31415
reviewed
Apr 15, 2024
andy31415
reviewed
Apr 15, 2024
andy31415
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for a V1, lets follow up with these updates:
- use temporary files for tests instead of fixed name
__resolve_env_vals__
change to return a new dict (and fix types: it returns a dict of string + bool instead of just string) instead of in-place modification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work for Issue #31317
PR #3 - We have a Metadata_Reader object that will be initialized by passing the path to the environment file. The public method of this class can be used to get metadata associated with a script.
Files Worked: