-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Darwin] MTRDevice attribute storage mutable array enumeration fix #32559
Merged
woody-apple
merged 6 commits into
project-chip:master
from
jtung-apple:jtung/darwin-mtrdevice-attribute-storage-array-fix
Mar 13, 2024
Merged
[Darwin] MTRDevice attribute storage mutable array enumeration fix #32559
woody-apple
merged 6 commits into
project-chip:master
from
jtung-apple:jtung/darwin-mtrdevice-attribute-storage-array-fix
Mar 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mhazley and
mkardous-silabs
March 13, 2024 15:01
pullapprove
bot
requested review from
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
March 13, 2024 15:01
PR #32559: Size comparison from 1160f97 to 6eb6869 Full report (31 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, k32w, linux, mbed, nrfconnect, qpg, stm32)
|
bzbarsky-apple
requested changes
Mar 13, 2024
PR #32559: Size comparison from 1160f97 to e444ab9 Full report (3 builds for cc32xx, stm32)
|
PR #32559: Size comparison from 1160f97 to 0ddd4ac Full report (7 builds for cc32xx, mbed, nrfconnect, stm32)
|
PR #32559: Size comparison from 1160f97 to fb399d4 Decreases (3 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #32559: Size comparison from 1160f97 to 1191da7 Full report (19 builds for cc13x4_26x4, cc32xx, k32w, mbed, nrfconnect, qpg, stm32)
|
bzbarsky-apple
approved these changes
Mar 13, 2024
PR #32559: Size comparison from 1160f97 to 62ff45e Decreases (3 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
yunhanw-google
approved these changes
Mar 13, 2024
huangxuyong
pushed a commit
to huangxuyong/connectedhomeip
that referenced
this pull request
Mar 19, 2024
…roject-chip#32559) * [Darwin] MTRDevice attribute storage mutable array enumeration fix * Added unit test and minor fixes * Unit test fix * Addressed review comments * Fixed / clarified logging for nodeID, endpoint, cluster, attribute * Fixed unit test race condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug where the mutable array is modified during enumeration.