Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LevelControl Move when no motion requested #32539

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Fix LevelControl Move when no motion requested #32539

merged 2 commits into from
Mar 12, 2024

Conversation

tcarmelveilleux
Copy link
Contributor

  • rate == 0 means "do not move", so handle it more efficiently without moving.

Testing done:

  • Added an integration test for the behavior.

@tcarmelveilleux tcarmelveilleux mentioned this pull request Mar 11, 2024
Closed
@tcarmelveilleux @volodymyr-zvarun-globallogic
Fix LevelControl Move when no motion requested
9bd2343 
- rate == 0 means "do not move", so handle it more efficiently
  without moving.

Testing done:
- Added an integration test for the behavior.

Co-authored-by: volodymyr-zvarun-globallogic <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 11, 2024 •
edited
Loading

PR #32539: Size comparison from 5aa5555 to a56ea11

Increases (38 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, stm32, telink)
platform target config section 5aa5555 a56ea11 change % change
bl602 lighting-app bl602 (read/write) 1437362 1437690 328 0.0
.rodata 158376 158448 72 0.0
.text 1103490 1103746 256 0.0
bl602+mfd (read/write) 1452034 1452106 72 0.0
.rodata 157336 157408 72 0.0
bl602+rpc (read/write) 1485010 1485330 320 0.0
.rodata 165952 166016 64 0.0
.text 1135136 1135392 256 0.0
bl702 lighting-app bl702 (read/write) 1201807 1202131 324 0.0
.rodata 107732 107800 68 0.1
.text 972390 972646 256 0.0
bl702+mfd (read/write) 1212859 1213183 324 0.0
.rodata 106672 106740 68 0.1
.text 984400 984656 256 0.0
bl702+rpc (read/write) 1293555 1293879 324 0.0
.rodata 123104 123172 68 0.1
.text 1047354 1047610 256 0.0
bl706-eth (read/write) 1019777 1019845 68 0.0
.rodata 101064 101132 68 0.1
bl706-wifi (read/write) 1254286 1254354 68 0.0
.rodata 122064 122132 68 0.1
bl702l lighting-app bl702l .rodata 101736 101804 68 0.1
.text 965488 965744 256 0.0
bl702l+mfd .rodata 100676 100744 68 0.1
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 773852 773980 128 0.0
.rodata 81756 81820 64 0.1
.text 691832 691896 64 0.0
pump-app LP_EM_CC1354P10_6 (read only) 731196 731308 112 0.0
.rodata 77420 77484 64 0.1
.text 653512 653560 48 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 569035 569091 56 0.0
.app_xip_area 458789 458845 56 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 933144 933400 256 0.0
.text 733788 734044 256 0.0
BRD4187C (read/write) 1110208 1110328 120 0.0
.text 911596 911716 120 0.0
esp32 all-clusters-app c3devkit (read only) 1211500 1211582 82 0.0
(read/write) 1749696 1749760 64 0.0
.flash.rodata 252224 252288 64 0.0
.flash.text 1211500 1211582 82 0.0
m5stack (read only) 1253771 1253831 60 0.0
(read/write) 536248 536312 64 0.0
.flash.rodata 283932 283996 64 0.0
.flash.text 1247607 1247667 60 0.0
k32w light k32w0+release (read only) 609928 609992 64 0.0
.text 609392 609456 64 0.0
k32w1+release (read/write) 790348 790468 120 0.0
.text 668352 668472 120 0.0
linux all-clusters-app debug (read only) 5923057 5923393 336 0.0
.rodata 349648 349712 64 0.0
.text 5140035 5140307 272 0.0
all-clusters-minimal-app debug (read only) 5203617 5203937 320 0.0
.rodata 288682 288746 64 0.0
.text 4680227 4680483 256 0.0
bridge-app debug (read only) 4598049 4598417 368 0.0
.rodata 229290 229386 96 0.0
.text 4148467 4148739 272 0.0
lighting-app debug+rpc+ui (read only) 5521689 5522025 336 0.0
.rodata 354484 354548 64 0.0
.text 4920531 4920803 272 0.0
shell debug (read only) 2890809 2891145 336 0.0
.rodata 185632 185696 64 0.0
.text 2531858 2532130 272 0.0
tv-app debug (read only) 5706017 5706369 352 0.0
.rodata 289994 290090 96 0.0
.text 5173939 5174195 256 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1103016 1103160 144 0.0
rodata 112864 112928 64 0.1
text 811472 811544 72 0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1222344 1222408 64 0.0
text 807088 807140 52 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1051260 1051408 148 0.0
rodata 100220 100288 68 0.1
text 773512 773584 72 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1796476 1796740 264 0.0
.text 1589188 1589452 264 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1718548 1718788 240 0.0
.text 1514404 1514644 240 0.0
light cy8ckit_062s2_43012 (read/write) 1637652 1637900 248 0.0
.text 1440236 1440484 248 0.0
qpg lighting-app qpg6105+debug (read/write) 1129820 1129964 144 0.0
.text 642200 642344 144 0.0
stm32 light STM32WB5MM-DK (read/write) 601033 601177 144 0.0
.rodata 79644 79716 72 0.1
.text 382648 382720 72 0.0
telink all-clusters-app tlsr9518adk80d (read/write) 1092628 1092776 148 0.0
text 793756 793838 82 0.0
all-clusters-minimal-app tlsr9528a (read/write) 1050100 1050248 148 0.0
text 765078 765160 82 0.0
bridge-app tlsr9518adk80d (read/write) 910804 910960 156 0.0
text 652552 652634 82 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read/write) 1073984 1074140 156 0.0
text 777940 778022 82 0.0
pump-app tlsr9258a_retention (read/write) 828138 828286 148 0.0
text 621398 621480 82 0.0
Decreases (3 builds for bl702l, efr32)
platform target config section 5aa5555 a56ea11 change % change
bl702l lighting-app bl702l (read/write) 1171892 1171704 -188 -0.0
bl702l+mfd (read/write) 1183300 1182856 -444 -0.0
efr32 window-app BRD4187C (read/write) 1156984 1156976 -8 -0.0
.text 986212 986204 -8 -0.0
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
platform target config section 5aa5555 a56ea11 change % change
bl602 lighting-app bl602 (read/write) 1437362 1437690 328 0.0
.bss 85352 85352 0 0.0
.data 9496 9496 0 0.0
.rodata 158376 158448 72 0.0
.text 1103490 1103746 256 0.0
bl602+mfd (read/write) 1452034 1452106 72 0.0
.bss 85512 85512 0 0.0
.data 9472 9472 0 0.0
.rodata 157336 157408 72 0.0
.text 1119064 1119064 0 0.0
bl602+rpc (read/write) 1485010 1485330 320 0.0
.bss 93384 93384 0 0.0
.data 9872 9872 0 0.0
.rodata 165952 166016 64 0.0
.text 1135136 1135392 256 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1201807 1202131 324 0.0
.bss 11133 11133 0 0.0
.data 3680 3680 0 0.0
.rodata 107732 107800 68 0.1
.text 972390 972646 256 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1212859 1213183 324 0.0
.bss 11309 11309 0 0.0
.data 3656 3656 0 0.0
.rodata 106672 106740 68 0.1
.text 984400 984656 256 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1293555 1293879 324 0.0
.bss 19613 19613 0 0.0
.data 4216 4216 0 0.0
.rodata 123104 123172 68 0.1
.text 1047354 1047610 256 0.0
bl706-eth (read/write) 1019777 1019845 68 0.0
.bss 23708 23708 0 0.0
.data 3256 3256 0 0.0
.rodata 101064 101132 68 0.1
.text 763774 763774 0 0.0
bl706-wifi (read/write) 1254286 1254354 68 0.0
.bss 10577 10577 0 0.0
.data 3688 3688 0 0.0
.rodata 122064 122132 68 0.1
.text 995546 995546 0 0.0
bl702l lighting-app bl702l (read/write) 1171892 1171704 -188 -0.0
.bss 16328 16328 0 0.0
.data 5040 5040 0 0.0
.rodata 101736 101804 68 0.1
.text 965488 965744 256 0.0
bl702l+mfd (read/write) 1183300 1182856 -444 -0.0
.bss 16504 16504 0 0.0
.data 5024 5024 0 0.0
.rodata 100676 100744 68 0.1
.text 977810 977810 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 773852 773980 128 0.0
(read/write) 168624 168624 0 0.0
.bss 90628 90628 0 0.0
.data 3560 3560 0 0.0
.rodata 81756 81820 64 0.1
.text 691832 691896 64 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 790388 790388 0 0.0
(read/write) 178872 178872 0 0.0
.bss 100876 100876 0 0.0
.data 3560 3560 0 0.0
.rodata 76004 76004 0 0.0
.text 714120 714120 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 779044 779044 0 0.0
(read/write) 173312 173312 0 0.0
.bss 95316 95316 0 0.0
.data 3560 3560 0 0.0
.rodata 102756 102756 0 0.0
.text 676024 676024 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 731196 731308 112 0.0
(read/write) 167592 167592 0 0.0
.bss 89360 89360 0 0.0
.data 3552 3552 0 0.0
.rodata 77420 77484 64 0.1
.text 653512 653560 48 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 716836 716836 0 0.0
(read/write) 167800 167800 0 0.0
.bss 89584 89584 0 0.0
.data 3544 3544 0 0.0
.rodata 73268 73268 0 0.0
.text 643304 643304 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 583266 583266 0 0.0
(read/write) 207992 207992 0 0.0
.bss 201228 201228 0 0.0
.data 1640 1640 0 0.0
.rodata 86602 86602 0 0.0
.text 494540 494540 0 0.0
lock CC3235SF_LAUNCHXL (read only) 628538 628538 0 0.0
(read/write) 208336 208336 0 0.0
.bss 201720 201720 0 0.0
.data 1496 1496 0 0.0
.rodata 107058 107058 0 0.0
.text 519356 519356 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 569035 569091 56 0.0
.app_xip_area 458789 458845 56 0.0
.bss 65080 65080 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 551763 551763 0 0.0
.app_xip_area 436757 436757 0 0.0
.bss 69832 69832 0 0.0
.data 752 752 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 571915 571915 0 0.0
.app_xip_area 463173 463173 0 0.0
.bss 63616 63616 0 0.0
.data 704 704 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 564819 564819 0 0.0
.app_xip_area 452797 452797 0 0.0
.bss 66816 66816 0 0.0
.data 784 784 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 933144 933400 256 0.0
.bss 197936 197936 0 0.0
.data 1396 1396 0 0.0
.text 733788 734044 256 0.0
BRD4187C (read/write) 1110208 1110328 120 0.0
.bss 195176 195176 0 0.0
.data 3416 3416 0 0.0
.text 911596 911716 120 0.0
lock-app BRD4161A+wf200 (read/write) 1122748 1122748 0 0.0
.bss 186788 186788 0 0.0
.data 2800 2800 0 0.0
.text 933140 933140 0 0.0
window-app BRD4187C (read/write) 1156984 1156976 -8 -0.0
.bss 167424 167424 0 0.0
.data 3328 3328 0 0.0
.text 986212 986204 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1211500 1211582 82 0.0
(read/write) 1749696 1749760 64 0.0
.dram0.bss 74320 74320 0 0.0
.dram0.data 13620 13620 0 0.0
.flash.rodata 252224 252288 64 0.0
.flash.text 1211500 1211582 82 0.0
.iram0.text 75530 75530 0 0.0
m5stack (read only) 1253771 1253831 60 0.0
(read/write) 536248 536312 64 0.0
.dram0.bss 81232 81232 0 0.0
.dram0.data 35164 35164 0 0.0
.flash.rodata 283932 283996 64 0.0
.flash.text 1247607 1247667 60 0.0
.iram0.text 125403 125403 0 0.0
k32w contact k32w0+release (read only) 606256 606256 0 0.0
(read/write) 79636 79636 0 0.0
.bss 67452 67452 0 0.0
.data 2200 2200 0 0.0
.text 605720 605720 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 747688 747688 0 0.0
.bss 79212 79212 0 0.0
.data 2816 2816 0 0.0
.text 626288 626288 0 0.0
light k32w0+release (read only) 609928 609992 64 0.0
(read/write) 79520 79520 0 0.0
.bss 67332 67332 0 0.0
.data 2204 2204 0 0.0
.text 609392 609456 64 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 790348 790468 120 0.0
.bss 80604 80604 0 0.0
.data 2032 2032 0 0.0
.text 668352 668472 120 0.0
lock k32w0+release (read only) 589792 589792 0 0.0
(read/write) 77508 77508 0 0.0
.bss 65372 65372 0 0.0
.data 2152 2152 0 0.0
.text 589256 589256 0 0.0
linux air-purifier-app debug (read only) 2617005 2617005 0 0.0
(read/write) 128960 128960 0 0.0
.bss 46544 46544 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 74248 74248 0 0.0
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 185008 185008 0 0.0
.text 2254533 2254533 0 0.0
all-clusters-app debug (read only) 5923057 5923393 336 0.0
(read/write) 480432 480432 0 0.0
.bss 134848 134848 0 0.0
.data 4528 4528 0 0.0
.data.rel.ro 333640 333640 0 0.0
.dynamic 624 624 0 0.0
.got 5360 5360 0 0.0
.init 27 27 0 0.0
.init_array 1384 1384 0 0.0
.rodata 349648 349712 64 0.0
.text 5140035 5140307 272 0.0
all-clusters-minimal-app debug (read only) 5203617 5203937 320 0.0
(read/write) 236384 236384 0 0.0
.bss 127680 127680 0 0.0
.data 4432 4432 0 0.0
.data.rel.ro 97208 97208 0 0.0
.dynamic 624 624 0 0.0
.got 5280 5280 0 0.0
.init 27 27 0 0.0
.init_array 1112 1112 0 0.0
.rodata 288682 288746 64 0.0
.text 4680227 4680483 256 0.0
bridge-app debug (read only) 4598049 4598417 368 0.0
(read/write) 217232 217232 0 0.0
.bss 118176 118176 0 0.0
.data 6208 6208 0 0.0
.data.rel.ro 86144 86144 0 0.0
.dynamic 624 624 0 0.0
.got 5248 5248 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 229290 229386 96 0.0
.text 4148467 4148739 272 0.0
chip-tool debug (read only) 12034041 12034041 0 0.0
(read/write) 521512 521512 0 0.0
.bss 94424 94424 0 0.0
.data 5122 5122 0 0.0
.data.rel.ro 414744 414744 0 0.0
.dynamic 624 624 0 0.0
.got 5768 5768 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 448665 448665 0 0.0
.text 10879603 10879603 0 0.0
chip-tool-ipv6only arm64 (read only) 11357580 11357580 0 0.0
(read/write) 588368 588368 0 0.0
.bss 103512 103512 0 0.0
.data 4496 4496 0 0.0
.data.rel.ro 454528 454528 0 0.0
.dynamic 512 512 0 0.0
.got 16976 16976 0 0.0
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 354508 354508 0 0.0
.text 10124760 10124760 0 0.0
lighting-app debug+rpc+ui (read only) 5521689 5522025 336 0.0
(read/write) 226024 226024 0 0.0
.bss 119144 119144 0 0.0
.data 4832 4832 0 0.0
.data.rel.ro 94544 94544 0 0.0
.dynamic 672 672 0 0.0
.got 5888 5888 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 354484 354548 64 0.0
.text 4920531 4920803 272 0.0
lock-app debug (read only) 4665777 4665777 0 0.0
(read/write) 204816 204816 0 0.0
.bss 113600 113600 0 0.0
.data 4128 4128 0 0.0
.data.rel.ro 80392 80392 0 0.0
.dynamic 624 624 0 0.0
.got 5200 5200 0 0.0
.init 27 27 0 0.0
.init_array 840 840 0 0.0
.rodata 255306 255306 0 0.0
.text 4198819 4198819 0 0.0
ota-provider-app debug (read only) 4297609 4297609 0 0.0
(read/write) 193288 193288 0 0.0
.bss 113280 113280 0 0.0
.data 4336 4336 0 0.0
.data.rel.ro 69776 69776 0 0.0
.dynamic 624 624 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 207850 207850 0 0.0
.text 3896787 3896787 0 0.0
ota-requestor-app debug (read only) 4427033 4427033 0 0.0
(read/write) 197720 197720 0 0.0
.bss 114208 114208 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 72896 72896 0 0.0
.dynamic 624 624 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 213962 213962 0 0.0
.text 4015555 4015555 0 0.0
shell debug (read only) 2890809 2891145 336 0.0
(read/write) 156352 156352 0 0.0
.bss 62736 62736 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 86464 86464 0 0.0
.dynamic 592 592 0 0.0
.got 4072 4072 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 185632 185696 64 0.0
.text 2531858 2532130 272 0.0
thermostat-no-ble arm64 (read only) 4417204 4417204 0 0.0
(read/write) 245736 245736 0 0.0
.bss 121832 121832 0 0.0
.data 3376 3376 0 0.0
.data.rel.ro 103624 103624 0 0.0
.dynamic 512 512 0 0.0
.got 8616 8616 0 0.0
.init 24 24 0 0.0
.init_array 424 424 0 0.0
.rodata 159388 159388 0 0.0
.text 3923176 3923176 0 0.0
tv-app debug (read only) 5706017 5706369 352 0.0
(read/write) 352584 352584 0 0.0
.bss 244368 244368 0 0.0
.data 6528 6528 0 0.0
.data.rel.ro 94424 94424 0 0.0
.dynamic 624 624 0 0.0
.got 5496 5496 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 289994 290090 96 0.0
.text 5173939 5174195 256 0.0
tv-casting-app debug (read only) 9864969 9864969 0 0.0
(read/write) 340296 340296 0 0.0
.bss 156272 156272 0 0.0
.data 2976 2976 0 0.0
.data.rel.ro 174176 174176 0 0.0
.dynamic 624 624 0 0.0
.got 5072 5072 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 383032 383032 0 0.0
.text 9016195 9016195 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2532304 2532304 0 0.0
.bss 220472 220472 0 0.0
.data 5200 5200 0 0.0
.text 1494988 1494988 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1103016 1103160 144 0.0
bss 130855 130855 0 0.0
rodata 112864 112928 64 0.1
text 811472 811544 72 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1222344 1222408 64 0.0
bss 122945 122945 0 0.0
rodata 141792 141792 0 0.0
text 807088 807140 52 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1051260 1051408 148 0.0
bss 129713 129713 0 0.0
rodata 100220 100288 68 0.1
text 773512 773584 72 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 834440 834440 0 0.0
(read/write) 1796476 1796740 264 0.0
.bss 196236 196236 0 0.0
.data 2664 2664 0 0.0
.text 1589188 1589452 264 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837584 837584 0 0.0
(read/write) 1718548 1718788 240 0.0
.bss 193116 193116 0 0.0
.data 2640 2640 0 0.0
.text 1514404 1514644 240 0.0
light cy8ckit_062s2_43012 (read only) 844312 844312 0 0.0
(read/write) 1637652 1637900 248 0.0
.bss 186580 186580 0 0.0
.data 2448 2448 0 0.0
.text 1440236 1440484 248 0.0
lock cy8ckit_062s2_43012 (read only) 817160 817160 0 0.0
(read/write) 1667540 1667540 0 0.0
.bss 213740 213740 0 0.0
.data 2440 2440 0 0.0
.text 1442972 1442972 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1129820 1129964 144 0.0
.bss 102480 102480 0 0.0
.data 824 824 0 0.0
.text 642200 642344 144 0.0
lock-app qpg6105+debug (read/write) 1089932 1089932 0 0.0
.bss 97224 97224 0 0.0
.data 844 844 0 0.0
.text 602316 602316 0 0.0
stm32 light STM32WB5MM-DK (read/write) 601033 601177 144 0.0
.bss 128344 128344 0 0.0
.data 668 668 0 0.0
.rodata 79644 79716 72 0.1
.text 382648 382720 72 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 823930 823930 0 0.0
bss 49684 49684 0 0.0
text 616728 616728 0 0.0
all-clusters-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 1092628 1092776 148 0.0
bss 101804 101804 0 0.0
text 793756 793838 82 0.0
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1050100 1050248 148 0.0
bss 110108 110108 0 0.0
text 765078 765160 82 0.0
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 910804 910960 156 0.0
bss 93140 93140 0 0.0
text 652552 652634 82 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 825562 825562 0 0.0
bss 49732 49732 0 0.0
text 618418 618418 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 931272 931272 0 0.0
bss 77732 77732 0 0.0
text 698562 698562 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1073984 1074140 156 0.0
bss 100220 100220 0 0.0
text 777940 778022 82 0.0
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 903672 903672 0 0.0
bss 69196 69196 0 0.0
text 653830 653830 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 929932 929932 0 0.0
bss 92720 92720 0 0.0
text 671712 671712 0 0.0
pump-app tlsr9258a_retention (read only) 51774 51774 0 0.0
(read/write) 828138 828286 148 0.0
bss 49840 49840 0 0.0
text 621398 621480 82 0.0
pump-controller-app tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 791860 791860 0 0.0
bss 56040 56040 0 0.0
text 592156 592156 0 0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 677224 677224 0 0.0
bss 73672 73672 0 0.0
text 462484 462484 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 833090 833090 0 0.0
bss 51364 51364 0 0.0
text 624788 624788 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 851821 851821 0 0.0
bss 59516 59516 0 0.0
text 636866 636866 0 0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 817508 817508 0 0.0
bss 56328 56328 0 0.0
text 611840 611840 0 0.0
window-covering tlsr9258a (read only) 51584 51584 0 0.0
(read/write) 835600 835600 0 0.0
bss 68104 68104 0 0.0
text 627096 627096 0 0.0

@mergify mergify bot merged commit 9cac277 into project-chip:master Mar 12, 2024
58 checks passed
huangxuyong pushed a commit to huangxuyong/connectedhomeip that referenced this pull request Mar 19, 2024
@tcarmelveilleux @volodymyr-zvarun-globallogic
@restyled-commits @huangxuyong
Fix LevelControl Move when no motion requested (project-chip#32539)
ab986ed 
* Fix LevelControl Move when no motion requested

- rate == 0 means "do not move", so handle it more efficiently
  without moving.

Testing done:
- Added an integration test for the behavior.

Co-authored-by: volodymyr-zvarun-globallogic <[email protected]>

* Restyled by prettier-yaml

---------

Co-authored-by: volodymyr-zvarun-globallogic <[email protected]>
Co-authored-by: Restyled.io <[email protected]>
cecille pushed a commit to cecille/connectedhomeip that referenced this pull request Apr 15, 2024
@tcarmelveilleux @volodymyr-zvarun-globallogic
@restyled-commits @cecille
Fix LevelControl Move when no motion requested (project-chip#32539)
97d435b 
* Fix LevelControl Move when no motion requested

- rate == 0 means "do not move", so handle it more efficiently
  without moving.

Testing done:
- Added an integration test for the behavior.

Co-authored-by: volodymyr-zvarun-globallogic <[email protected]>

* Restyled by prettier-yaml

---------

Co-authored-by: volodymyr-zvarun-globallogic <[email protected]>
Co-authored-by: Restyled.io <[email protected]>
mergify bot pushed a commit that referenced this pull request Apr 16, 2024
@cecille @tcarmelveilleux
@volodymyr-zvarun-globallogic @restyled-commits
Fix LevelControl Move when no motion requested (#32539) (#32993)
11f94c3 
* Fix LevelControl Move when no motion requested

- rate == 0 means "do not move", so handle it more efficiently
  without moving.

Testing done:
- Added an integration test for the behavior.



* Restyled by prettier-yaml

---------

Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>
Co-authored-by: volodymyr-zvarun-globallogic <[email protected]>
Co-authored-by: Restyled.io <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkardous-silabs mkardous-silabs mkardous-silabs approved these changes

@yufengwangca yufengwangca yufengwangca approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app cherry picked to 1.3 review - approved tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tcarmelveilleux @yufengwangca @mkardous-silabs @andy31415 @restyled-commits