-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a few gaps in jumping between Java and C++ for Messages cluster #32295
Merged
mergify
merged 1 commit into
project-chip:master
from
robszewczyk:message_duration_fixes
Feb 23, 2024
Merged
Fix a few gaps in jumping between Java and C++ for Messages cluster #32295
mergify
merged 1 commit into
project-chip:master
from
robszewczyk:message_duration_fixes
Feb 23, 2024
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix dangling problems arising from uint16 seconds for duration to uint64_t milliseconds
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mhazley
February 23, 2024 19:01
pullapprove
bot
requested review from
rcasallas-silabs,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
February 23, 2024 19:01
chrisdecenzo
approved these changes
Feb 23, 2024
PR #32295: Size comparison from 9cf74ab to 1958365 Decreases (3 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
andy31415
approved these changes
Feb 23, 2024
yufengwangca
approved these changes
Feb 23, 2024
pidarped
approved these changes
Feb 23, 2024
yunhanw-google
approved these changes
Feb 23, 2024
yunhanw-google
changed the title
Fix a a few gaps in jumping between Java and C++ for Messages cluster
Fix a few gaps in jumping between Java and C++ for Messages cluster
Feb 23, 2024
hasty
approved these changes
Feb 23, 2024
huangxuyong
pushed a commit
to huangxuyong/connectedhomeip
that referenced
this pull request
Mar 19, 2024
…project-chip#32295) Fix dangling problems arising from uint16 seconds for duration to uint64_t milliseconds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix dangling problems arising from uint16 seconds for duration to uint64_t milliseconds (problems introduced in #32248