-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Messages cluster sample app for android #32162
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdecenzo
requested review from
yunhanw-google,
xylophone21 and
amitnj
and removed request for
yunhanw-google and
xylophone21
February 16, 2024 12:01
andy31415
reviewed
Feb 16, 2024
examples/tv-app/android/java/src/com/matter/tv/server/tvapp/Message.java
Outdated
Show resolved
Hide resolved
examples/tv-app/android/java/src/com/matter/tv/server/tvapp/MessageResponseOption.java
Outdated
Show resolved
Hide resolved
pullapprove
bot
requested review from
vivien-apple,
tehampson,
woody-apple,
wiba-nordic,
tima-q,
younghak-hwang,
tobiasgraf and
turon
February 19, 2024 10:19
lazarkov
approved these changes
Feb 19, 2024
sharadb-amazon
approved these changes
Feb 19, 2024
examples/tv-app/android/java/src/com/matter/tv/server/tvapp/Message.java
Show resolved
Hide resolved
examples/tv-app/android/java/src/com/matter/tv/server/tvapp/MessageResponseOption.java
Show resolved
Hide resolved
examples/tv-app/android/java/src/com/matter/tv/server/tvapp/MessagesManagerStub.java
Outdated
Show resolved
Hide resolved
yunhanw-google
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approval assume comments can be addressed, thanks
bhmanda-silabs
pushed a commit
to bhmanda-silabs/connectedhomeip
that referenced
this pull request
Feb 22, 2024
* sample app for java * present and list messages * address feedback * Restyle [in-dev] Messages cluster sample app for android (project-chip#32163) * Restyled by whitespace * Restyled by google-java-format --------- Co-authored-by: Restyled.io <[email protected]> * Restyled by google-java-format (project-chip#32195) Co-authored-by: Restyled.io <[email protected]> * address feedback --------- Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com> Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add message cluster server implementation to the android tv-app sample