-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Scenes] Precondition TC_S_3_1 #32005
Merged
lpbeliveau-silabs
merged 3 commits into
project-chip:master
from
lpbeliveau-silabs:feature/scenes_TC_3_1_precondition_step
Feb 15, 2024
Merged
[Scenes] Precondition TC_S_3_1 #32005
lpbeliveau-silabs
merged 3 commits into
project-chip:master
from
lpbeliveau-silabs:feature/scenes_TC_3_1_precondition_step
Feb 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpbeliveau-silabs
force-pushed
the
feature/scenes_TC_3_1_precondition_step
branch
from
February 7, 2024 21:21
25b4a9b
to
9f387e8
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
February 7, 2024 21:21
pullapprove
bot
requested review from
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
February 7, 2024 21:21
PR #32005: Size comparison from f658ea2 to 9f387e8 Decreases (2 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
raju-apple
approved these changes
Feb 12, 2024
tehampson
reviewed
Feb 12, 2024
lpbeliveau-silabs
force-pushed
the
feature/scenes_TC_3_1_precondition_step
branch
from
February 13, 2024 17:12
d38846f
to
7d27042
Compare
PR #32005: Size comparison from 239ef48 to 7d27042 Decreases (1 build for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
tehampson
approved these changes
Feb 13, 2024
jmartinez-silabs
approved these changes
Feb 15, 2024
raul-marquez-csa
pushed a commit
to raul-marquez-csa/connectedhomeip
that referenced
this pull request
Feb 16, 2024
* Added a precondition step to TC_S_3_1 * Split preconditionning into separate steps * Applied nit
lpbeliveau-silabs
deleted the
feature/scenes_TC_3_1_precondition_step
branch
December 10, 2024 14:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a precondition step to TC_S_3_1 to add the require group key and group to run all the following steps.
Also update the verification steps of TC_S_3_1 match the Verification Steps Document.
Fixes: project-chip/matter-test-scripts#123