-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESP32] Diagnostic logs provider delegate implementation in temperature-meausement-app #31682
Merged
woody-apple
merged 7 commits into
project-chip:master
from
shubhamdp:esp32_diagnostics_logs
Feb 2, 2024
Merged
[ESP32] Diagnostic logs provider delegate implementation in temperature-meausement-app #31682
woody-apple
merged 7 commits into
project-chip:master
from
shubhamdp:esp32_diagnostics_logs
Feb 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
January 25, 2024 12:02
pullapprove
bot
requested review from
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
January 25, 2024 12:02
PR #31682: Size comparison from e5f5d67 to 1e31f75 Increases above 0.2%:
Increases (2 builds for esp32)
Decreases (1 build for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
dhrishi
approved these changes
Jan 29, 2024
examples/temperature-measurement-app/esp32/main/diagnostic_logs/end_user_support.log
Outdated
Show resolved
Hide resolved
examples/temperature-measurement-app/esp32/main/diagnostic_logs/network_diag.log
Outdated
Show resolved
Hide resolved
temperature-measurement-app zap file
temperature-measurement-app
address review comments
shubhamdp
force-pushed
the
esp32_diagnostics_logs
branch
from
January 29, 2024 09:02
1e31f75
to
a839531
Compare
PR #31682: Size comparison from f63b505 to 8202a7a Decreases (1 build for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
@vivien-apple Can you please review? |
woody-apple
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Tests