-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Fix crash in getConnectedDevicePointer #31471
Merged
andy31415
merged 2 commits into
project-chip:master
from
yunhanw-google:feature/fix_jni_session_creation_crash
Jan 19, 2024
Merged
[Android] Fix crash in getConnectedDevicePointer #31471
andy31415
merged 2 commits into
project-chip:master
from
yunhanw-google:feature/fix_jni_session_creation_crash
Jan 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #31471: Size comparison from 09f014c to ae817b6 Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yunhanw-google
changed the title
Fix crash in getConnectedDevicePointer
[Android] Fix crash in getConnectedDevicePointer
Jan 17, 2024
joonhaengHeo
approved these changes
Jan 18, 2024
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn and
Damian-Nordic
January 18, 2024 16:40
pullapprove
bot
requested review from
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple and
yufengwangca
January 18, 2024 16:40
yufengwangca
approved these changes
Jan 18, 2024
yunhanw-google
force-pushed
the
feature/fix_jni_session_creation_crash
branch
from
January 18, 2024 18:01
7c0ac33
to
8cbb54b
Compare
PR #31471: Size comparison from 9c94fe6 to 8cbb54b Decreases (2 builds for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Jan 19, 2024
lpbeliveau-silabs
pushed a commit
to lpbeliveau-silabs/connectedhomeip
that referenced
this pull request
Jan 19, 2024
* Fix crash in getConnectedDevicePointer * Restyled by clang-format --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When CASE session is not established and error appears in getConnectedDevicePointer, we should expose this error to java/kotlin layer so that the Coroutine can finish.