Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Telink] Remove define of CHIP_ADDRESS_RESOLVE_IMPL_INCLUDE_HEADER. #31390

Merged
merged 5 commits into from
Jan 16, 2024
Merged

[Telink] Remove define of CHIP_ADDRESS_RESOLVE_IMPL_INCLUDE_HEADER. #31390

merged 5 commits into from
Jan 16, 2024

Conversation

andy31415
Copy link
Contributor

This define should not be at a platform level and should only be pulled in via dependencies.

I believe this was pulled in before we fixed ICD layering and dependencies. I do not expect this to be needed anymore and if we get ICD build errors we should fix ICD instead.

@andy31415
Remove define of CHIP_ADDRESS_RESOLVE_IMPL_INCLUDE_HEADER.
3eb4efe 
This define should not be at a platform level and should only be pulled
in via dependencies.
@andy31415 andy31415 changed the title Remove define of CHIP_ADDRESS_RESOLVE_IMPL_INCLUDE_HEADER. [Telink] Remove define of CHIP_ADDRESS_RESOLVE_IMPL_INCLUDE_HEADER. Jan 12, 2024
@andy31415 andy31415 mentioned this pull request Jan 12, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 12, 2024 •
edited
Loading

PR #31390: Size comparison from eb7a27c to 3eb4efe

Decreases (1 build for efr32)
platform target config section eb7a27c 3eb4efe change % change
efr32 window-app BRD4187C (read/write) 1138656 1138648 -8 -0.0
.text 968420 968412 -8 -0.0
Full report (56 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
platform target config section eb7a27c 3eb4efe change % change
bl602 lighting-app bl602 (read/write) 1419922 1419922 0 0.0
.bss 85184 85184 0 0.0
.data 9488 9488 0 0.0
.rodata 156980 156980 0 0.0
.text 1087626 1087626 0 0.0
bl602+mfd (read/write) 1434394 1434394 0 0.0
.bss 85352 85352 0 0.0
.data 9456 9456 0 0.0
.rodata 155940 155940 0 0.0
.text 1102994 1102994 0 0.0
bl602+rpc (read/write) 1467698 1467698 0 0.0
.bss 93216 93216 0 0.0
.data 9856 9856 0 0.0
.rodata 164596 164596 0 0.0
.text 1119370 1119370 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1184963 1184963 0 0.0
.bss 11133 11133 0 0.0
.data 3656 3656 0 0.0
.rodata 106352 106352 0 0.0
.text 957290 957290 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1196095 1196095 0 0.0
.bss 11309 11309 0 0.0
.data 3640 3640 0 0.0
.rodata 105292 105292 0 0.0
.text 969354 969354 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1276639 1276639 0 0.0
.bss 19597 19597 0 0.0
.data 4216 4216 0 0.0
.rodata 121772 121772 0 0.0
.text 1032096 1032096 0 0.0
bl706-eth (read/write) 1004081 1004081 0 0.0
.bss 23692 23692 0 0.0
.data 3232 3232 0 0.0
.rodata 99684 99684 0 0.0
.text 749696 749696 0 0.0
bl706-wifi (read/write) 1234966 1234966 0 0.0
.bss 10577 10577 0 0.0
.data 3672 3672 0 0.0
.rodata 120664 120664 0 0.0
.text 977822 977822 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1154604 1154604 0 0.0
.bss 16328 16328 0 0.0
.data 5024 5024 0 0.0
.rodata 100356 100356 0 0.0
.text 950416 950416 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1165800 1165800 0 0.0
.bss 16504 16504 0 0.0
.data 5000 5000 0 0.0
.rodata 99296 99296 0 0.0
.text 962536 962536 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 778096 778096 0 0.0
(read/write) 168380 168380 0 0.0
.bss 90452 90452 0 0.0
.data 3524 3524 0 0.0
.rodata 88824 88824 0 0.0
.text 689008 689008 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 794168 794168 0 0.0
(read/write) 178608 178608 0 0.0
.bss 100628 100628 0 0.0
.data 3552 3552 0 0.0
.rodata 83080 83080 0 0.0
.text 710820 710820 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 782416 782416 0 0.0
(read/write) 173064 173064 0 0.0
.bss 95084 95084 0 0.0
.data 3552 3552 0 0.0
.rodata 109688 109688 0 0.0
.text 672460 672460 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 735040 735040 0 0.0
(read/write) 167384 167384 0 0.0
.bss 89232 89232 0 0.0
.data 3512 3512 0 0.0
.rodata 84416 84416 0 0.0
.text 650360 650360 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 720552 720552 0 0.0
(read/write) 167564 167564 0 0.0
.bss 89416 89416 0 0.0
.data 3508 3508 0 0.0
.rodata 80256 80256 0 0.0
.text 640032 640032 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 567938 567938 0 0.0
(read/write) 207744 207744 0 0.0
.bss 201028 201028 0 0.0
.data 1592 1592 0 0.0
.rodata 83962 83962 0 0.0
.text 481852 481852 0 0.0
lock CC3235SF_LAUNCHXL (read only) 621298 621298 0 0.0
(read/write) 208144 208144 0 0.0
.bss 201504 201504 0 0.0
.data 1520 1520 0 0.0
.rodata 105834 105834 0 0.0
.text 513340 513340 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 562303 562303 0 0.0
.app_xip_area 452457 452457 0 0.0
.bss 64688 64688 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 544543 544543 0 0.0
.app_xip_area 429961 429961 0 0.0
.bss 69384 69384 0 0.0
.data 772 772 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 563215 563215 0 0.0
.app_xip_area 454825 454825 0 0.0
.bss 63272 63272 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 558823 558823 0 0.0
.app_xip_area 447201 447201 0 0.0
.bss 66392 66392 0 0.0
.data 804 804 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1042240 1042240 0 0.0
.bss 192656 192656 0 0.0
.data 2776 2776 0 0.0
.text 846788 846788 0 0.0
BRD4187C (read/write) 1105288 1105288 0 0.0
.bss 194932 194932 0 0.0
.data 3384 3384 0 0.0
.text 906952 906952 0 0.0
lock-app BRD4161A+wf200 (read/write) 1118204 1118204 0 0.0
.bss 188040 188040 0 0.0
.data 2800 2800 0 0.0
.text 927344 927344 0 0.0
window-app BRD4187C (read/write) 1138656 1138648 -8 -0.0
.bss 166924 166924 0 0.0
.data 3292 3292 0 0.0
.text 968420 968412 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1153736 1153736 0 0.0
(read/write) 1669232 1669232 0 0.0
.dram0.bss 71640 71640 0 0.0
.dram0.data 13588 13588 0 0.0
.flash.rodata 240000 240000 0 0.0
.flash.text 1153736 1153736 0 0.0
.iram0.text 75530 75530 0 0.0
m5stack (read only) 1199999 1199999 0 0.0
(read/write) 519852 519852 0 0.0
.dram0.bss 78504 78504 0 0.0
.dram0.data 35132 35132 0 0.0
.flash.rodata 270296 270296 0 0.0
.flash.text 1193835 1193835 0 0.0
.iram0.text 125403 125403 0 0.0
k32w contact k32w0+release (read only) 606680 606680 0 0.0
(read/write) 81172 81172 0 0.0
.bss 68952 68952 0 0.0
.data 2236 2236 0 0.0
.text 606144 606144 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 691964 691964 0 0.0
.bss 67608 67608 0 0.0
.data 2788 2788 0 0.0
.text 578096 578096 0 0.0
light k32w0+release (read only) 596080 596080 0 0.0
(read/write) 79188 79188 0 0.0
.bss 67016 67016 0 0.0
.data 2188 2188 0 0.0
.text 595544 595544 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 783776 783776 0 0.0
.bss 77284 77284 0 0.0
.data 2000 2000 0 0.0
.text 661040 661040 0 0.0
lock k32w0+release (read only) 577512 577512 0 0.0
(read/write) 78644 78644 0 0.0
.bss 66496 66496 0 0.0
.data 2164 2164 0 0.0
.text 576976 576976 0 0.0
linux air-purifier-app debug (read only) 2535893 2535893 0 0.0
(read/write) 127248 127248 0 0.0
.bss 46272 46272 0 0.0
.data 2144 2144 0 0.0
.data.rel.ro 72856 72856 0 0.0
.dynamic 608 608 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 179752 179752 0 0.0
.text 2180693 2180693 0 0.0
all-clusters-app debug (read only) 5434121 5434121 0 0.0
(read/write) 457920 457920 0 0.0
.bss 131184 131184 0 0.0
.data 4448 4448 0 0.0
.data.rel.ro 315016 315016 0 0.0
.dynamic 624 624 0 0.0
.got 5336 5336 0 0.0
.init 27 27 0 0.0
.init_array 1288 1288 0 0.0
.rodata 314396 314396 0 0.0
.text 4707635 4707635 0 0.0
all-clusters-minimal-app debug (read only) 4963641 4963641 0 0.0
(read/write) 234760 234760 0 0.0
.bss 127280 127280 0 0.0
.data 4384 4384 0 0.0
.data.rel.ro 95976 95976 0 0.0
.dynamic 624 624 0 0.0
.got 5296 5296 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 272973 272973 0 0.0
.text 4458211 4458211 0 0.0
bridge-app debug (read only) 4426753 4426753 0 0.0
(read/write) 216032 216032 0 0.0
.bss 117848 117848 0 0.0
.data 6144 6144 0 0.0
.data.rel.ro 85312 85312 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 219605 219605 0 0.0
.text 3988531 3988531 0 0.0
chip-tool debug (read only) 11770185 11770185 0 0.0
(read/write) 505976 505976 0 0.0
.bss 94200 94200 0 0.0
.data 5058 5058 0 0.0
.data.rel.ro 399472 399472 0 0.0
.dynamic 624 624 0 0.0
.got 5784 5784 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 429337 429337 0 0.0
.text 10651491 10651491 0 0.0
chip-tool-ipv6only arm64 (read only) 11343488 11343488 0 0.0
(read/write) 573520 573520 0 0.0
.bss 103256 103256 0 0.0
.data 4472 4472 0 0.0
.data.rel.ro 438704 438704 0 0.0
.dynamic 512 512 0 0.0
.got 20032 20032 0 0.0
.init 24 24 0 0.0
.init_array 240 240 0 0.0
.rodata 340044 340044 0 0.0
.text 10133804 10133804 0 0.0
lighting-app debug+rpc+ui (read only) 5312649 5312649 0 0.0
(read/write) 225040 225040 0 0.0
.bss 118912 118912 0 0.0
.data 4864 4864 0 0.0
.data.rel.ro 93728 93728 0 0.0
.dynamic 672 672 0 0.0
.got 5880 5880 0 0.0
.init 27 27 0 0.0
.init_array 968 968 0 0.0
.rodata 340852 340852 0 0.0
.text 4726963 4726963 0 0.0
lock-app debug (read only) 4512049 4512049 0 0.0
(read/write) 203688 203688 0 0.0
.bss 113312 113312 0 0.0
.data 4096 4096 0 0.0
.data.rel.ro 79544 79544 0 0.0
.dynamic 624 624 0 0.0
.got 5216 5216 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 247541 247541 0 0.0
.text 4054435 4054435 0 0.0
ota-provider-app debug (read only) 4176009 4176009 0 0.0
(read/write) 192704 192704 0 0.0
.bss 113248 113248 0 0.0
.data 4256 4256 0 0.0
.data.rel.ro 69312 69312 0 0.0
.dynamic 624 624 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 201749 201749 0 0.0
.text 3782339 3782339 0 0.0
ota-requestor-app debug (read only) 4266969 4266969 0 0.0
(read/write) 196984 196984 0 0.0
.bss 114144 114144 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 72288 72288 0 0.0
.dynamic 624 624 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 205589 205589 0 0.0
.text 3865155 3865155 0 0.0
shell debug (read only) 2804737 2804737 0 0.0
(read/write) 152672 152672 0 0.0
.bss 61864 61864 0 0.0
.data 1344 1344 0 0.0
.data.rel.ro 83656 83656 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 1104 1104 0 0.0
.rodata 182688 182688 0 0.0
.text 2450674 2450674 0 0.0
thermostat-no-ble arm64 (read only) 4354920 4354920 0 0.0
(read/write) 246296 246296 0 0.0
.bss 121624 121624 0 0.0
.data 3328 3328 0 0.0
.data.rel.ro 102752 102752 0 0.0
.dynamic 512 512 0 0.0
.got 12088 12088 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 155772 155772 0 0.0
.text 3856636 3856636 0 0.0
tv-app debug (read only) 5413449 5413449 0 0.0
(read/write) 349184 349184 0 0.0
.bss 243168 243168 0 0.0
.data 6464 6464 0 0.0
.data.rel.ro 92248 92248 0 0.0
.dynamic 624 624 0 0.0
.got 5512 5512 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 273685 273685 0 0.0
.text 4902067 4902067 0 0.0
tv-casting-app debug (read only) 9642929 9642929 0 0.0
(read/write) 337904 337904 0 0.0
.bss 155936 155936 0 0.0
.data 2912 2912 0 0.0
.data.rel.ro 172192 172192 0 0.0
.dynamic 624 624 0 0.0
.got 5064 5064 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 365832 365832 0 0.0
.text 8815811 8815811 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2526976 2526976 0 0.0
.bss 220240 220240 0 0.0
.data 5208 5208 0 0.0
.text 1489660 1489660 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1070524 1070524 0 0.0
bss 129376 129376 0 0.0
rodata 105628 105628 0 0.0
text 787800 787800 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1196584 1196584 0 0.0
bss 121586 121586 0 0.0
rodata 139340 139340 0 0.0
text 785184 785184 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1041448 1041448 0 0.0
bss 129300 129300 0 0.0
rodata 98888 98888 0 0.0
text 765448 765448 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 835728 835728 0 0.0
(read/write) 1754532 1754532 0 0.0
.bss 194996 194996 0 0.0
.data 2616 2616 0 0.0
.text 1548532 1548532 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837816 837816 0 0.0
(read/write) 1707380 1707380 0 0.0
.bss 192908 192908 0 0.0
.data 2616 2616 0 0.0
.text 1503468 1503468 0 0.0
light cy8ckit_062s2_43012 (read only) 844504 844504 0 0.0
(read/write) 1632292 1632292 0 0.0
.bss 186404 186404 0 0.0
.data 2432 2432 0 0.0
.text 1435068 1435068 0 0.0
lock cy8ckit_062s2_43012 (read only) 817384 817384 0 0.0
(read/write) 1659196 1659196 0 0.0
.bss 213500 213500 0 0.0
.data 2456 2456 0 0.0
.text 1434852 1434852 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1117832 1117832 0 0.0
.bss 101224 101224 0 0.0
.data 808 808 0 0.0
.text 630212 630212 0 0.0
lock-app qpg6105+debug (read/write) 1081752 1081752 0 0.0
.bss 97520 97520 0 0.0
.data 852 852 0 0.0
.text 594128 594128 0 0.0

@s07641069 s07641069 mentioned this pull request Jan 15, 2024
Merged
@mergify mergify bot merged commit 943b870 into project-chip:master Jan 16, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@s07641069 s07641069 s07641069 approved these changes

@cecille cecille cecille approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@dhrishi dhrishi Awaiting requested review from dhrishi

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
config examples platform review - approved telink
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@andy31415 @cecille @s07641069 @Damian-Nordic @jmartinez-silabs @andriy-bilynskyy