-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TimeSnapshot command and add TC-DGGEN-2.4 #31179
Fix TimeSnapshot command and add TC-DGGEN-2.4 #31179
Conversation
PR #31179: Size comparison from 70ac7e0 to 5f3e188 Increases above 0.2%:
Increases (59 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (2 builds for cc32xx)
Full report (62 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
it seems we also need to update lighting-app for your change? thanks Build: GN configure |
PR #31179: Size comparison from 70ac7e0 to 6a19e1e Increases (3 builds for cc32xx, mbed)
Decreases (2 builds for cc32xx)
Full report (3 builds for cc32xx, mbed)
|
PR #31179: Size comparison from b364ee6 to d6e42b0 Increases (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (3 builds for cc32xx, linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
src/app/clusters/general-diagnostics-server/general-diagnostics-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/general-diagnostics-server/general-diagnostics-server.cpp
Show resolved
Hide resolved
src/app/clusters/general-diagnostics-server/general-diagnostics-server.cpp
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the comments are addressed.
Fixes #30096
Issue #31177
Testing done: