-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]Microwave oven control cluster implementation - add watt setting #31130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248 and
hicklin
December 20, 2023 09:29
PR #31130: Size comparison from 4676d27 to 23abc48 Increases (4 builds for linux)
Decreases (2 builds for efr32, linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Jan 15, 2024
examples/microwave-oven-app/microwave-oven-common/src/microwave-oven-device.cpp
Show resolved
Hide resolved
andy31415
reviewed
Jan 15, 2024
examples/microwave-oven-app/microwave-oven-common/src/microwave-oven-device.cpp
Show resolved
Hide resolved
andy31415
reviewed
Jan 15, 2024
src/app/clusters/microwave-oven-control-server/microwave-oven-control-server.cpp
Outdated
Show resolved
Hide resolved
andy31415
reviewed
Jan 15, 2024
src/app/clusters/microwave-oven-control-server/microwave-oven-control-server.cpp
Outdated
Show resolved
Hide resolved
andy31415
reviewed
Jan 15, 2024
src/app/clusters/microwave-oven-control-server/microwave-oven-control-server.cpp
Outdated
Show resolved
Hide resolved
andy31415
approved these changes
Jan 15, 2024
rbultman
reviewed
Jan 15, 2024
examples/microwave-oven-app/microwave-oven-common/include/microwave-oven-device.h
Outdated
Show resolved
Hide resolved
src/app/clusters/microwave-oven-control-server/microwave-oven-control-server.h
Outdated
Show resolved
Hide resolved
examples/microwave-oven-app/microwave-oven-common/include/microwave-oven-device.h
Outdated
Show resolved
Hide resolved
examples/microwave-oven-app/microwave-oven-common/microwave-oven-app.zap
Show resolved
Hide resolved
PR #31130: Size comparison from 7ef397e to 4265e66 Increases (5 builds for esp32, linux)
Decreases (2 builds for efr32, linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #31130: Size comparison from 943b870 to 55854d7 Increases (5 builds for esp32, linux)
Decreases (2 builds for efr32, linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
rbultman
reviewed
Jan 16, 2024
src/app/clusters/microwave-oven-control-server/microwave-oven-control-server.cpp
Outdated
Show resolved
Hide resolved
rbultman
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one suggested change.
bzbarsky-apple
approved these changes
Jan 16, 2024
PR #31130: Size comparison from c4f7024 to b2d8108 Increases above 0.2%:
Increases (4 builds for linux)
Decreases (1 build for esp32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lpbeliveau-silabs
pushed a commit
to lpbeliveau-silabs/connectedhomeip
that referenced
this pull request
Jan 17, 2024
…ting (project-chip#31130) * update .xml and .json * add src/controller * regen ZAP, add new attributes for microwave oven control cluster * update MicrowaveOvenDevice SDK and APP * update comment for MWO * Restyled by whitespace * Restyled by clang-format * Restyled by prettier-json * Restyled by isort * update XML * update MWO after reviewed * Restyled by clang-format * update MWO sdk after reviewed * Restyled by clang-format * update microwave-oven-device.h * update MWC-wattSetting after reviewed * update comment for HandleSetCookingParametersCallback method * update MWOCTRL, add new feature PowerInLimits * push test * Restyled by whitespace * Restyled by clang-format * regen_all and rebuild * update MWOCTRL after review * Restyled by whitespace * Restyled by clang-format * update code after reviewed * update code after reviewed * Restyled by whitespace * Restyled by clang-format * Restyled by autopep8 * update code after reviewed * update code after reviewed * Restyled by whitespace * Restyled by clang-format * update code, adding new checking for powerSetting Number * fix restyled issue * Restyled by whitespace * Restyled by clang-format * update code after reviewed * fix restyled issue * Restyled by whitespace * Restyled by clang-format * update code after reviewed * Restyled by clang-format --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app
appliances
Stuff related to appliance types and clusters
controller
darwin
examples
microwaves
review - approved
skip-protocol-compatibility
Marker that protocol backwards compatibility checks are to be skipped
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microwave oven control cluster implementation - add watt setting
fixes: #31106
fixes: #31122