-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dead !HAVE_LWIP_UDP_BIND_NETIF configuration #31045
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This define came in with the initial import, but we never provided any way to turn it off. Remove that case as dead code.
mspang
force-pushed
the
for-chip/lwip_bind_netif
branch
from
December 15, 2023 18:44
2271b7f
to
e72182f
Compare
Android doesn't use lwIP, and the NDK has stdint.h, so this seems pretty strange. Remove it.
PR #31045: Size comparison from 964c855 to e72182f Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #31045: Size comparison from 964c855 to 3511d2a Increases above 0.2%:
Increases (30 builds for bl602, esp32, linux, nrfconnect, psoc6, telink)
Decreases (44 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
December 15, 2023 20:57
pullapprove
bot
requested review from
nivi-apple,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
December 15, 2023 20:57
mkardous-silabs
approved these changes
Dec 15, 2023
woody-apple
approved these changes
Dec 15, 2023
thivya-amazon
pushed a commit
to thivya-amazon/connectedhomeip
that referenced
this pull request
Dec 18, 2023
* Remove dead !HAVE_LWIP_UDP_BIND_NETIF configuration This define came in with the initial import, but we never provided any way to turn it off. Remove that case as dead code. * Remove LWIP_NO_STDINT_H on Android Android doesn't use lwIP, and the NDK has stdint.h, so this seems pretty strange. Remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This define came in with the initial import, but we never provided any way to turn it off. Remove that case as dead code.