-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to using lowercase built-in types consistently in XML. #30740
Merged
mergify
merged 2 commits into
project-chip:master
from
bzbarsky-apple:lowercase-remaining-types
Nov 30, 2023
Merged
Switch to using lowercase built-in types consistently in XML. #30740
mergify
merged 2 commits into
project-chip:master
from
bzbarsky-apple:lowercase-remaining-types
Nov 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already did this for enums and bitmaps and ints, though some more uppercase ones snuck in. This converts those snuck-in bits, arrays, and single/double to lowercase.
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
November 30, 2023 15:00
pullapprove
bot
requested review from
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yufengwangca
November 30, 2023 15:00
pullapprove
bot
added
review - pending
examples
controller
app
and removed
examples
controller
app
labels
Nov 30, 2023
andy31415
approved these changes
Nov 30, 2023
PR #30740: Size comparison from ce4befc to 68f32c7 Full report (8 builds for cc32xx, mbed, nrfconnect, qpg)
|
bzbarsky-apple
added
the
skip-protocol-compatibility
Marker that protocol backwards compatibility checks are to be skipped
label
Nov 30, 2023
bzbarsky-apple
force-pushed
the
lowercase-remaining-types
branch
from
November 30, 2023 15:26
68f32c7
to
bd9e303
Compare
yunhanw-google
approved these changes
Nov 30, 2023
PR #30740: Size comparison from ce4befc to bd9e303 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app
controller
examples
fast track
review - pending
skip-protocol-compatibility
Marker that protocol backwards compatibility checks are to be skipped
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Only the first changeset here is manual; the second is auto-generated.
We already did this for enums and bitmaps and ints, though some more uppercase ones snuck in.
This converts those snuck-in bits, arrays, and single/double to lowercase.