-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ReportScheduler] Fixed chunked reporting for Synchronized Report Scheduler #30608
Merged
mergify
merged 4 commits into
project-chip:master
from
lpbeliveau-silabs:bugfix/Synchronized_Chunked_Reports
Dec 5, 2023
Merged
[ReportScheduler] Fixed chunked reporting for Synchronized Report Scheduler #30608
mergify
merged 4 commits into
project-chip:master
from
lpbeliveau-silabs:bugfix/Synchronized_Chunked_Reports
Dec 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpbeliveau-silabs
force-pushed
the
bugfix/Synchronized_Chunked_Reports
branch
from
November 21, 2023 20:08
24d1603
to
ecb73f9
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
LuDuda and
mhazley
November 21, 2023 20:08
PR #30608: Size comparison from 971e060 to ecb73f9 Increases (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (2 builds for linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lpbeliveau-silabs
force-pushed
the
bugfix/Synchronized_Chunked_Reports
branch
4 times, most recently
from
November 23, 2023 03:54
da4cf7b
to
5742cbe
Compare
PR #30608: Size comparison from a454ccd to 5742cbe Increases (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
Decreases (3 builds for bl702l, linux)
Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
mkardous-silabs
approved these changes
Nov 23, 2023
PR #30608: Size comparison from a454ccd to fb4e991 Increases above 0.2%:
Increases (61 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, k32w, linux, mbed, qpg, telink)
Decreases (2 builds for bl702l, linux)
Full report (62 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, k32w, linux, mbed, qpg, telink)
|
lpbeliveau-silabs
force-pushed
the
bugfix/Synchronized_Chunked_Reports
branch
from
November 23, 2023 17:06
fb4e991
to
43c3a08
Compare
PR #30608: Size comparison from 953df8a to 43c3a08 Increases (61 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, k32w, linux, mbed, qpg, telink)
Decreases (2 builds for linux)
Full report (62 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, k32w, linux, mbed, qpg, telink)
|
…eduler and added tests for Syncrhonized report scheduler interaction Also fixed behavior of Synchronized Report scheduler on Early Reports cases
Co-authored-by: Junior Martinez <[email protected]>
lpbeliveau-silabs
force-pushed
the
bugfix/Synchronized_Chunked_Reports
branch
from
November 23, 2023 19:23
43c3a08
to
70b091c
Compare
PR #30608: Size comparison from 3eb9c02 to 70b091c Increases (3 builds for cc32xx, mbed)
Full report (3 builds for cc32xx, mbed)
|
lpbeliveau-silabs
force-pushed
the
bugfix/Synchronized_Chunked_Reports
branch
from
November 23, 2023 19:36
70b091c
to
1373772
Compare
PR #30608: Size comparison from 3eb9c02 to 1373772 Increases (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (2 builds for linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Nov 24, 2023
PR #30608: Size comparison from 3eb9c02 to 735ecf6 Increases (29 builds for bl602, bl702, cc32xx, efr32, esp32, linux, mbed, nrfconnect, psoc6)
Decreases (56 builds for bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, qpg, telink)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug where chunked report would not be properly handled by synchronised report scheduler and added a version of TestReadInteraction unit test that would perform all the read interaction tests while using the synchronized report scheduler.
The Report Synchronisation logic has also been changed so it gets rescheduled if a timer somehow fired too early for its handler's min interval.
Fixes: #30518