-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nrfconnect] Removed overwriting mbedTLS configs handled by OT #30577
Merged
mergify
merged 1 commit into
project-chip:master
from
maciejbaczmanski:matter_mbedtls_configs
Nov 20, 2023
Merged
[nrfconnect] Removed overwriting mbedTLS configs handled by OT #30577
mergify
merged 1 commit into
project-chip:master
from
maciejbaczmanski:matter_mbedtls_configs
Nov 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed overwriting mbedTLS configs handled by OpenThread Kconfig: * MBEDTLS_TLS_LIBRARY * MBEDTLS_ECJPAKE_C Are handled in sdk-nrf repository in `subsys/net/openthread/Kconfig` They should not be overwritten by Matter config. Signed-off-by: Maciej Baczmanski <[email protected]>
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
November 20, 2023 11:19
pullapprove
bot
requested review from
nivi-apple,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
November 20, 2023 11:19
Damian-Nordic
approved these changes
Nov 20, 2023
PR #30577: Size comparison from 64a6594 to ca86220 Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Nov 20, 2023
maciejbaczmanski
added a commit
to maciejbaczmanski/connectedhomeip
that referenced
this pull request
Jul 15, 2024
…d by OT (project-chip#30577) Removed overwriting mbedTLS configs handled by OpenThread Kconfig: * MBEDTLS_TLS_LIBRARY * MBEDTLS_ECJPAKE_C Are handled in sdk-nrf repository in `subsys/net/openthread/Kconfig` They should not be overwritten by Matter config. Signed-off-by: Maciej Baczmanski <[email protected]> (cherry picked from commit 4922ea6)
maciejbaczmanski
pushed a commit
to maciejbaczmanski/connectedhomeip
that referenced
this pull request
Jul 15, 2024
…s handled by OT (project-chip#30577)" This reverts commit 1b16138.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed overwriting mbedTLS configs handled by OpenThread Kconfig:
Are handled in sdk-nrf repository in
subsys/net/openthread/Kconfig
They should not be overwritten by Matter config.