-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ICD] Send Check-In messages #30526
Merged
jepenven-silabs
merged 4 commits into
project-chip:master
from
jepenven-silabs:icd_send_checkin_msg
Nov 28, 2023
Merged
[ICD] Send Check-In messages #30526
jepenven-silabs
merged 4 commits into
project-chip:master
from
jepenven-silabs:icd_send_checkin_msg
Nov 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
examples
app
tests
icd
Intermittently Connected Devices
messaging
labels
Nov 16, 2023
jepenven-silabs
force-pushed
the
icd_send_checkin_msg
branch
from
November 16, 2023 19:30
23003e0
to
608d236
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple and
lazarkov
November 16, 2023 19:31
jepenven-silabs
force-pushed
the
icd_send_checkin_msg
branch
2 times, most recently
from
November 22, 2023 15:58
e4cf72c
to
84ad149
Compare
jepenven-silabs
force-pushed
the
icd_send_checkin_msg
branch
from
November 22, 2023 16:08
84ad149
to
8dedece
Compare
PR #30526: Size comparison from 28ddbeb to 8dedece Increases above 0.2%:
Increases (15 builds for linux, psoc6, qpg, telink)
Decreases (17 builds for cc13x4_26x4, cyw30739, efr32, k32w, qpg, telink)
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, mbed, psoc6, qpg, telink)
|
mkardous-silabs
approved these changes
Nov 27, 2023
andy31415
reviewed
Nov 27, 2023
andy31415
reviewed
Nov 27, 2023
andy31415
reviewed
Nov 27, 2023
andy31415
approved these changes
Nov 27, 2023
bzbarsky-apple
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #28229
Fix #24243
Add Logic to trigger sending of the ICD Check-In message