Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pigweed environment paths absolute #30493

Merged

Conversation

andy31415
Copy link
Contributor

Fixes #30475

It turns out figuring out how to set paths is not as easy, so forcing absolute paths in our pigweed_environment whenever a path looks like out-of-root.

Will look at pigweed to set better paths in some way, but for now unlock builds of RPC.
Previous fix I had did not work on efr32 even though it fixed esp32 because efr and esp have different example paths.

Tested:

source scripts/bootstrap.sh && ./scripts/build/build_examples.py --target esp32-m5stack-all-clusters-rpc-ipv6only --target  efr32-brd4161a-lock-rpc-openthread_mtd build

Copy link

github-actions bot commented Nov 15, 2023

PR #30493: Size comparison from 26ec08f to 81f666a

Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 26ec08f 81f666a change % change
bl602 lighting-app bl602 (read/write) 1408614 1408614 0 0.0
.bss 84512 84512 0 0.0
.data 9376 9376 0 0.0
.rodata 156456 156456 0 0.0
.text 1077620 1077620 0 0.0
bl602+mfd (read/write) 1423070 1423070 0 0.0
.bss 84680 84680 0 0.0
.data 9344 9344 0 0.0
.rodata 155416 155416 0 0.0
.text 1092972 1092972 0 0.0
bl602+rpc (read/write) 1456134 1456134 0 0.0
.bss 92544 92544 0 0.0
.data 9744 9744 0 0.0
.rodata 164072 164072 0 0.0
.text 1109108 1109108 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1174787 1174787 0 0.0
.bss 11197 11197 0 0.0
.data 3560 3560 0 0.0
.rodata 106192 106192 0 0.0
.text 948114 948114 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1185655 1185655 0 0.0
.bss 11373 11373 0 0.0
.data 3536 3536 0 0.0
.rodata 105132 105132 0 0.0
.text 959922 959922 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1274851 1274851 0 0.0
.bss 19677 19677 0 0.0
.data 4112 4112 0 0.0
.rodata 121600 121600 0 0.0
.text 1023180 1023180 0 0.0
bl706-eth (read/write) 993721 993721 0 0.0
.bss 23772 23772 0 0.0
.data 3128 3128 0 0.0
.rodata 99280 99280 0 0.0
.text 740586 740586 0 0.0
bl706-wifi (read/write) 1228970 1228970 0 0.0
.bss 10657 10657 0 0.0
.data 3568 3568 0 0.0
.rodata 120140 120140 0 0.0
.text 965116 965116 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1144500 1144500 0 0.0
.bss 16408 16408 0 0.0
.data 4920 4920 0 0.0
.rodata 100196 100196 0 0.0
.text 941208 941208 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1155960 1155960 0 0.0
.bss 16584 16584 0 0.0
.data 4904 4904 0 0.0
.rodata 99136 99136 0 0.0
.text 953584 953584 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 738163 738163 0 0.0
(read/write) 166544 166544 0 0.0
.bss 88956 88956 0 0.0
.data 3424 3424 0 0.0
.rodata 84735 84735 0 0.0
.text 653036 653036 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 756987 756987 0 0.0
(read/write) 176764 176764 0 0.0
.bss 99132 99132 0 0.0
.data 3444 3444 0 0.0
.rodata 79815 79815 0 0.0
.text 676780 676780 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 743667 743667 0 0.0
(read/write) 171220 171220 0 0.0
.bss 93588 93588 0 0.0
.data 3444 3444 0 0.0
.rodata 105511 105511 0 0.0
.text 637764 637764 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 697707 697707 0 0.0
(read/write) 165636 165636 0 0.0
.bss 87816 87816 0 0.0
.data 3412 3412 0 0.0
.rodata 80455 80455 0 0.0
.text 616860 616860 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 683387 683387 0 0.0
(read/write) 165768 165768 0 0.0
.bss 87960 87960 0 0.0
.data 3408 3408 0 0.0
.rodata 76287 76287 0 0.0
.text 606708 606708 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 564610 564610 0 0.0
(read/write) 206496 206496 0 0.0
.bss 199956 199956 0 0.0
.data 1416 1416 0 0.0
.rodata 83730 83730 0 0.0
.text 478756 478756 0 0.0
lock CC3235SF_LAUNCHXL (read only) 616834 616834 0 0.0
(read/write) 206836 206836 0 0.0
.bss 200272 200272 0 0.0
.data 1444 1444 0 0.0
.rodata 105522 105522 0 0.0
.text 509192 509192 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 555479 555479 0 0.0
.app_xip_area 446537 446537 0 0.0
.bss 63856 63856 0 0.0
.data 664 664 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 538927 538927 0 0.0
.app_xip_area 425257 425257 0 0.0
.bss 68552 68552 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577087 577087 0 0.0
.app_xip_area 469481 469481 0 0.0
.bss 62592 62592 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 553095 553095 0 0.0
.app_xip_area 442401 442401 0 0.0
.bss 65576 65576 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1009652 1009652 0 0.0
.bss 171928 171928 0 0.0
.data 2696 2696 0 0.0
.text 835008 835008 0 0.0
BRD4187C (read/write) 1095620 1095620 0 0.0
.bss 195580 195580 0 0.0
.data 3304 3304 0 0.0
.text 896716 896716 0 0.0
lock-app BRD4161A+wf200 (read/write) 1103392 1103392 0 0.0
.bss 186576 186576 0 0.0
.data 2708 2708 0 0.0
.text 914084 914084 0 0.0
window-app BRD4187C (read/write) 1131720 1131720 0 0.0
.bss 167980 167980 0 0.0
.data 3176 3176 0 0.0
.text 960544 960544 0 0.0
esp32 all-clusters-app c3devkit (read only) 1130772 1130772 0 0.0
(read/write) 1670188 1670188 0 0.0
.dram0.bss 71864 71864 0 0.0
.dram0.data 12996 12996 0 0.0
.flash.rodata 241448 241448 0 0.0
.flash.text 1130772 1130772 0 0.0
.iram0.text 75694 75694 0 0.0
m5stack (read only) 1175875 1175875 0 0.0
(read/write) 520176 520176 0 0.0
.dram0.bss 78504 78504 0 0.0
.dram0.data 34020 34020 0 0.0
.flash.rodata 273288 273288 0 0.0
.flash.text 1170491 1170491 0 0.0
.iram0.text 123907 123907 0 0.0
k32w contact k32w0+release (read only) 591908 591908 0 0.0
(read/write) 87608 87608 0 0.0
.bss 70848 70848 0 0.0
.data 2136 2136 0 0.0
.text 591372 591372 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 687000 687000 0 0.0
.bss 67048 67048 0 0.0
.data 2720 2720 0 0.0
.text 573752 573752 0 0.0
light k32w0+release (read only) 591628 591628 0 0.0
(read/write) 87284 87284 0 0.0
.bss 70536 70536 0 0.0
.data 2124 2124 0 0.0
.text 591092 591092 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 779028 779028 0 0.0
.bss 76724 76724 0 0.0
.data 1932 1932 0 0.0
.text 656912 656912 0 0.0
lock k32w0+release (read only) 563460 563460 0 0.0
(read/write) 85112 85112 0 0.0
.bss 68424 68424 0 0.0
.data 2064 2064 0 0.0
.text 562924 562924 0 0.0
linux air-purifier-app debug (read only) 2489285 2489285 0 0.0
(read/write) 126608 126608 0 0.0
.bss 46880 46880 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 72248 72248 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 177032 177032 0 0.0
.text 2138021 2138021 0 0.0
all-clusters-app debug (read only) 5297625 5297625 0 0.0
(read/write) 424888 424888 0 0.0
.bss 129104 129104 0 0.0
.data 3856 3856 0 0.0
.data.rel.ro 284688 284688 0 0.0
.dynamic 624 624 0 0.0
.got 5352 5352 0 0.0
.init 27 27 0 0.0
.init_array 1216 1216 0 0.0
.rodata 301020 301020 0 0.0
.text 4611843 4611843 0 0.0
all-clusters-minimal-app debug (read only) 4904377 4904377 0 0.0
(read/write) 233472 233472 0 0.0
.bss 126928 126928 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 95632 95632 0 0.0
.dynamic 624 624 0 0.0
.got 5312 5312 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 269933 269933 0 0.0
.text 4402931 4402931 0 0.0
bridge-app debug (read only) 4384633 4384633 0 0.0
(read/write) 215456 215456 0 0.0
.bss 119128 119128 0 0.0
.data 4704 4704 0 0.0
.data.rel.ro 84864 84864 0 0.0
.dynamic 624 624 0 0.0
.got 5280 5280 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 218005 218005 0 0.0
.text 3948867 3948867 0 0.0
chip-tool debug (read only) 10586801 10586801 0 0.0
(read/write) 458472 458472 0 0.0
.bss 94008 94008 0 0.0
.data 4994 4994 0 0.0
.data.rel.ro 352232 352232 0 0.0
.dynamic 624 624 0 0.0
.got 5784 5784 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 397929 397929 0 0.0
.text 9569667 9569667 0 0.0
chip-tool-ipv6only arm64 (read only) 10445696 10445696 0 0.0
(read/write) 525056 525056 0 0.0
.bss 103320 103320 0 0.0
.data 4296 4296 0 0.0
.data.rel.ro 389944 389944 0 0.0
.dynamic 512 512 0 0.0
.got 18824 18824 0 0.0
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 322664 322664 0 0.0
.text 9329864 9329864 0 0.0
lighting-app debug+rpc+ui (read only) 5250049 5250049 0 0.0
(read/write) 223688 223688 0 0.0
.bss 118592 118592 0 0.0
.data 4384 4384 0 0.0
.data.rel.ro 93168 93168 0 0.0
.dynamic 672 672 0 0.0
.got 5896 5896 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 337588 337588 0 0.0
.text 4668867 4668867 0 0.0
lock-app debug (read only) 4469793 4469793 0 0.0
(read/write) 203072 203072 0 0.0
.bss 113536 113536 0 0.0
.data 3648 3648 0 0.0
.data.rel.ro 79144 79144 0 0.0
.dynamic 624 624 0 0.0
.got 5232 5232 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 245909 245909 0 0.0
.text 4014611 4014611 0 0.0
ota-provider-app debug (read only) 4133937 4133937 0 0.0
(read/write) 192288 192288 0 0.0
.bss 113568 113568 0 0.0
.data 3920 3920 0 0.0
.data.rel.ro 68880 68880 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 200309 200309 0 0.0
.text 3742563 3742563 0 0.0
ota-requestor-app debug (read only) 4220225 4220225 0 0.0
(read/write) 196536 196536 0 0.0
.bss 114592 114592 0 0.0
.data 4192 4192 0 0.0
.data.rel.ro 71840 71840 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 204053 204053 0 0.0
.text 3820803 3820803 0 0.0
shell debug (read only) 2755257 2755257 0 0.0
(read/write) 148896 148896 0 0.0
.bss 59752 59752 0 0.0
.data 784 784 0 0.0
.data.rel.ro 82560 82560 0 0.0
.dynamic 592 592 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 179136 179136 0 0.0
.text 2405458 2405458 0 0.0
thermostat-no-ble arm64 (read only) 4372488 4372488 0 0.0
(read/write) 245192 245192 0 0.0
.bss 122184 122184 0 0.0
.data 2800 2800 0 0.0
.data.rel.ro 101864 101864 0 0.0
.dynamic 512 512 0 0.0
.got 11936 11936 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 161540 161540 0 0.0
.text 3871704 3871704 0 0.0
tv-app debug (read only) 5254041 5254041 0 0.0
(read/write) 344984 344984 0 0.0
.bss 242336 242336 0 0.0
.data 4992 4992 0 0.0
.data.rel.ro 90352 90352 0 0.0
.dynamic 624 624 0 0.0
.got 5520 5520 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 266749 266749 0 0.0
.text 4752531 4752531 0 0.0
tv-casting-app debug (read only) 8518881 8518881 0 0.0
(read/write) 319488 319488 0 0.0
.bss 156192 156192 0 0.0
.data 2464 2464 0 0.0
.data.rel.ro 153984 153984 0 0.0
.dynamic 624 624 0 0.0
.got 5064 5064 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 344136 344136 0 0.0
.text 7757811 7757811 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2521952 2521952 0 0.0
.bss 219008 219008 0 0.0
.data 5136 5136 0 0.0
.text 1484636 1484636 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1055080 1055080 0 0.0
bss 128355 128355 0 0.0
rodata 104168 104168 0 0.0
text 774980 774980 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1181920 1181920 0 0.0
bss 120557 120557 0 0.0
rodata 138360 138360 0 0.0
text 772676 772676 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1040548 1040548 0 0.0
bss 128648 128648 0 0.0
rodata 99436 99436 0 0.0
text 764764 764764 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 837616 837616 0 0.0
(read/write) 1733500 1733500 0 0.0
.bss 193244 193244 0 0.0
.data 2480 2480 0 0.0
.text 1529388 1529388 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 839336 839336 0 0.0
(read/write) 1697372 1697372 0 0.0
.bss 191524 191524 0 0.0
.data 2480 2480 0 0.0
.text 1494980 1494980 0 0.0
light cy8ckit_062s2_43012 (read only) 845888 845888 0 0.0
(read/write) 1623556 1623556 0 0.0
.bss 185084 185084 0 0.0
.data 2368 2368 0 0.0
.text 1427716 1427716 0 0.0
lock cy8ckit_062s2_43012 (read only) 818688 818688 0 0.0
(read/write) 1652148 1652148 0 0.0
.bss 212268 212268 0 0.0
.data 2384 2384 0 0.0
.text 1429108 1429108 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1113432 1113432 0 0.0
.bss 100672 100672 0 0.0
.data 748 748 0 0.0
.text 625808 625808 0 0.0
lock-app qpg6105+debug (read/write) 1074556 1074556 0 0.0
.bss 95448 95448 0 0.0
.data 780 780 0 0.0
.text 586932 586932 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51910 51910 0 0.0
(read/write) 815518 815518 0 0.0
bss 53224 53224 0 0.0
text 609746 609746 0 0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1072332 1072332 0 0.0
bss 99400 99400 0 0.0
text 755756 755756 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1077244 1077244 0 0.0
bss 109096 109096 0 0.0
text 747448 747448 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 930820 930820 0 0.0
bss 93688 93688 0 0.0
text 643700 643700 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51910 51910 0 0.0
(read/write) 815630 815630 0 0.0
bss 53276 53276 0 0.0
text 609950 609950 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 969868 969868 0 0.0
bss 77076 77076 0 0.0
text 687876 687876 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1087120 1087120 0 0.0
bss 99204 99204 0 0.0
text 764564 764564 0 0.0
lock-app-dfu tlsr9528a_retention (read only) 51910 51910 0 0.0
(read/write) 869394 869394 0 0.0
bss 53916 53916 0 0.0
text 637062 637062 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 944116 944116 0 0.0
bss 91796 91796 0 0.0
text 659442 659442 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 872300 872300 0 0.0
bss 67112 67112 0 0.0
text 616500 616500 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 812864 812864 0 0.0
bss 55356 55356 0 0.0
text 583476 583476 0 0.0
resource-monitoring-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 828540 828540 0 0.0
bss 55760 55760 0 0.0
text 594066 594066 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 705712 705712 0 0.0
bss 73232 73232 0 0.0
text 462250 462250 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51910 51910 0 0.0
(read/write) 817358 817358 0 0.0
bss 53368 53368 0 0.0
text 612680 612680 0 0.0
temperature-measurement-app tlsr9528a_retention (read only) 51910 51910 0 0.0
(read/write) 805286 805286 0 0.0
bss 53108 53108 0 0.0
text 602330 602330 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 836884 836884 0 0.0
bss 55644 55644 0 0.0
text 601624 601624 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 831400 831400 0 0.0
bss 55996 55996 0 0.0
text 595858 595858 0 0.0

@andy31415
Copy link
Contributor Author

Fast track: fix for devel vscode and cloudbuild. CI cannot fully validate this (if compiles start, all should be ok).

@andy31415 andy31415 merged commit 1f61ebd into project-chip:master Nov 15, 2023
56 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RPC builds fail when PW_ENVIRONMENT_ROOT is set out of tree
2 participants