-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] Add .rps support in the build step and flasher script #30444
Merged
mkardous-silabs
merged 8 commits into
project-chip:master
from
mkardous-silabs:feature/add_917_flasher
Nov 15, 2023
Merged
[Silabs] Add .rps support in the build step and flasher script #30444
mkardous-silabs
merged 8 commits into
project-chip:master
from
mkardous-silabs:feature/add_917_flasher
Nov 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #30444: Size comparison from 33441cb to a54a5e0 Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kkasperczyk-no
November 14, 2023 14:58
pullapprove
bot
requested review from
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
November 14, 2023 14:58
PR #30444: Size comparison from 33441cb to a085ee4 Increases (3 builds for linux, psoc6)
Decreases (10 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, linux, mbed, psoc6, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
mkardous-silabs
force-pushed
the
feature/add_917_flasher
branch
from
November 14, 2023 20:49
228a32c
to
df659f0
Compare
mkardous-silabs
changed the title
[Silabs] Add rps ext to silabs flasher tools
[Silabs] Add .rps support in the build step and falsher script
Nov 14, 2023
PR #30444: Size comparison from ba772fe to d4a2eea Full report (32 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
andy31415
approved these changes
Nov 14, 2023
mkardous-silabs
changed the title
[Silabs] Add .rps support in the build step and falsher script
[Silabs] Add .rps support in the build step and flasher script
Nov 14, 2023
mkardous-silabs
force-pushed
the
feature/add_917_flasher
branch
from
November 14, 2023 22:15
98f2d2f
to
890ea43
Compare
PR #30444: Size comparison from 95a4042 to 890ea43 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Silabs uses two different extensions for binaries.
Add support for the
.rps
in the build script to generate the file and in the flasher to flash the .rps file.Tests
Manual tests to validate that the correct extension is used based on the board being built