-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nrfconnect] Remove redundant defines from CHIPProjectConfig.h #30190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
November 2, 2023 23:12
pullapprove
bot
requested review from
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
November 2, 2023 23:12
PR #30190: Size comparison from e574fd8 to 01e7e87 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Nov 2, 2023
yufengwangca
approved these changes
Nov 3, 2023
Most test device parameters can be configured via Kconfig, so configuring them directly in CHIPProjectConfig.h is unnecessary and confusing (it is unclear which source of the configuration takes precedence). Map Kconfig options to CHIP_DEVICE_XXX C defines unconditionally to detect macro redefinitions. Then, remove redundant defines from nRF Connect examples' CHIPProjectConfig.h files.
Damian-Nordic
force-pushed
the
proj-cfg-cleanup
branch
from
November 3, 2023 08:16
01e7e87
to
99ece59
Compare
PR #30190: Size comparison from 24d38da to 99ece59 Full report (10 builds for cc32xx, k32w, mbed, qpg)
|
PR #30190: Size comparison from 24d38da to f1d88d9 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
arkq
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most test device parameters can be configured via Kconfig, so configuring them directly in CHIPProjectConfig.h is unnecessary and confusing (it is unclear which source of the configuration takes precedence).
Map Kconfig options to CHIP_DEVICE_XXX C defines unconditionally to detect macro redefinitions. Then, remove redundant defines from nRF Connect examples' CHIPProjectConfig.h files.