-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kotlin] Uses Kotlin's coroutines to handle the asynchronous operation and returns the result directly #30082
Merged
yufengwangca
merged 2 commits into
project-chip:master
from
yufengwangca:pr/kotlin/callback
Oct 30, 2023
Merged
[Kotlin] Uses Kotlin's coroutines to handle the asynchronous operation and returns the result directly #30082
yufengwangca
merged 2 commits into
project-chip:master
from
yufengwangca:pr/kotlin/callback
Oct 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel and
ksperling-apple
October 30, 2023 06:19
pullapprove
bot
requested review from
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
October 30, 2023 06:19
joonhaengHeo
approved these changes
Oct 30, 2023
PR #30082: Size comparison from 2b91805 to f40f901 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Oct 30, 2023
fengdx4
pushed a commit
to fengdx4/connectedhomeip
that referenced
this pull request
Oct 31, 2023
…n and returns the result directly (project-chip#30082) * Update the kotlin type mapping * Remove callback from fun
shripad621git
pushed a commit
to shripad621git/connectedhomeip
that referenced
this pull request
Oct 31, 2023
…n and returns the result directly (project-chip#30082) * Update the kotlin type mapping * Remove callback from fun
mergify bot
pushed a commit
that referenced
this pull request
Nov 1, 2023
* add microwave oven mode cluster xml * zap generated * Restyled by prettier-json * update cluster-revision * updated MicorwaveOvenMode for mode-base-cluster.xml * Bump third_party/imgui/repo from `001f102` to `88fec09` (#30086) Bumps [third_party/imgui/repo](https://github.com/ocornut/imgui) from `001f102` to `88fec09`. - [Release notes](https://github.com/ocornut/imgui/releases) - [Commits](ocornut/imgui@001f102...88fec09) --- updated-dependencies: - dependency-name: third_party/imgui/repo dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump third_party/libwebsockets/repo from `a1cbc02` to `816544f` (#30083) Bumps [third_party/libwebsockets/repo](https://github.com/warmcat/libwebsockets) from `a1cbc02` to `816544f`. - [Commits](warmcat/libwebsockets@a1cbc02...816544f) --- updated-dependencies: - dependency-name: third_party/libwebsockets/repo dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump third_party/ot-br-posix/repo from `69ce2a5` to `184d298` (#30084) Bumps [third_party/ot-br-posix/repo](https://github.com/openthread/ot-br-posix) from `69ce2a5` to `184d298`. - [Release notes](https://github.com/openthread/ot-br-posix/releases) - [Commits](openthread/ot-br-posix@69ce2a5...184d298) --- updated-dependencies: - dependency-name: third_party/ot-br-posix/repo dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Make `Power source configuration cluster` match the spec (minor type change) (#30062) * Type of sources should be endpoint_no instead of raw int8u * Zap regen * Make `Localization Configuration Cluster` match the spec (#30058) * Switch XML to get manage privilege for activeLocale write * ZAP regen * [TI] Feature ti sysconfig 1 16 2 update (#30073) * Update README Files to reference latest SYSCONFIG Version * Update Sysconfig version for CI * Update docker version * [Kotlin] Uses Kotlin's coroutines to handle the asynchronous operation and returns the result directly (#30082) * Update the kotlin type mapping * Remove callback from fun * Update `Temperature Measurement Cluster` to spec (#30093) * Update data type * ZAP regen * esp32: make the shell command line buffer size configurable (#30050) * [nrfconnect] Updated nRF Connect SDK version in Docker to 2.5.0 (#30051) Regular update of nRF Connect SDK to 2.5.0 version including zephyr toolchain and west versions bump. * Make timedInvokeTimeoutMs optional (#30099) * fix MicrowaveOvenMode xml files and re-commit * fix adding MicrowaveOvenMode xml environment problem * revised MicrowaveOvenMode xml for the value of revision * commit to revise revision value and fix environment problem for MicrowaveOvenMode * revised merged src/controller/data_model/BUILD.gn --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: mideayanghui <[email protected]> Co-authored-by: Restyled.io <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: adabreuti <[email protected]> Co-authored-by: Yufeng Wang <[email protected]> Co-authored-by: Wang Qixiang <[email protected]> Co-authored-by: Kamil Kasperczyk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Kotlin API uses a callback (ChangeChannelResponseCallback) to handle the asynchronous result (or error).
Refactor the function to use Kotlin's coroutines (indicated by the suspend keyword) to handle the asynchronous operation and returns the result directly (ChangeChannelResponse).