-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python CSA DM XML parsing support for derived clusters #30036
Merged
mergify
merged 22 commits into
project-chip:master
from
andy31415:support_derived_clusters
Oct 27, 2023
Merged
Add python CSA DM XML parsing support for derived clusters #30036
mergify
merged 22 commits into
project-chip:master
from
andy31415:support_derived_clusters
Oct 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran and
hawk248
October 26, 2023 20:25
pullapprove
bot
requested review from
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
October 26, 2023 20:25
PR #30036: Size comparison from 1f9814e to fef1f28 Full report (5 builds for cc32xx, mbed, qpg)
|
PR #30036: Size comparison from 1f9814e to f50e4fb Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
scripts/py_matter_idl/matter_idl/data_model_xml/handlers/__init__.py
Outdated
Show resolved
Hide resolved
scripts/py_matter_idl/matter_idl/data_model_xml/handlers/__init__.py
Outdated
Show resolved
Hide resolved
tcarmelveilleux
approved these changes
Oct 27, 2023
PR #30036: Size comparison from 02e7647 to 776a0eb Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
shripad621git
pushed a commit
to shripad621git/connectedhomeip
that referenced
this pull request
Oct 31, 2023
…hip#30036) * Start preparing to store derived clusters * reformat, make sure parsing works * More leniency to allow ModeBase parsing * More leniency and documentation, be ready to attach base clusters * Refactor to add some separate derivation logic * Restyle * More work on actually handling inheritance * Restyle * Implement actual base class derivation * Add unit test for derived, make diffs a LOT better * Restyle * Switch to unified diff for a nicer diff view * Return after the first assert * Make type checker happy at places * Make mypy happy even on an edge case * Fix linter errors * Restyle * more typing for attrs * Some name changes for base clusters: use abstract to make it clear that other clusters could be base too * Also change variable name --------- Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: