Commissioning time sync: copy parameters to autocommissioner #29908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #29908: Size comparison from 7287731 to d5e0ea5 Increases (1 build for linux)
Full report (19 builds for cc13x4_26x4, cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple and
lazarkov
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #29908: Size comparison from 7287731 to 6fc80bc Increases above 0.2%:
Increases (15 builds for cc13x4_26x4, k32w, linux, qpg)
Full report (63 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, k32w, linux, mbed, nrfconnect, qpg, telink)
|
andy31415
reviewed
Oct 23, 2023
andy31415
approved these changes
Oct 23, 2023
woody-apple
approved these changes
Oct 23, 2023
|
PR #29908: Size comparison from 7287731 to f414b09 Increases above 0.2%:
Increases (22 builds for bl702, cc13x4_26x4, cc32xx, k32w, linux, qpg)
Decreases (8 builds for bl702, bl702l, cc32xx)
Full report (63 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, k32w, linux, mbed, nrfconnect, qpg, telink)
|
This was referenced Oct 24, 2023
| if (mTimeZoneBuf[i].name.HasValue()) | ||
| { | ||
| auto span = MutableCharSpan(mTimeZoneNames[i], kMaxTimeZoneNameLen); | ||
| CopyCharSpanToMutableCharSpan(mTimeZoneBuf[i].name.Value(), span); |
There was a problem hiding this comment.
If this fails, won't this leave garbage data in mTimeZoneNames[i]? And leave span as garbage pointing to possibly un-initialized memory too?
There was a problem hiding this comment.
why would that ever fail? It's a statically allocated buffer that's been size checked.
There was a problem hiding this comment.
I don't think mTimeZoneBuf[i].name.Value() has been size-checked...
shripad621git
pushed a commit
to shripad621git/connectedhomeip
that referenced
this pull request
Oct 31, 2023
…-chip#29908) * Commissioning time sync: copy parameters to autocommissioner * Restyled by clang-format * use a min function rather than being crazy --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The auto commissioner is meant to take ownership of the supplied buffers from the caller. PR adds static buffers for time zone and DST. Unfortunately, neither is trivially destructible until we move from chip::Optional to std::optional. For now, they are static, we can move to dynamic allocation if required once we have support and can use proper memory management tools.