-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update following change in the support for the StartUpMode attribute for the RVC device type #29862
Merged
mergify
merged 3 commits into
project-chip:master
from
dysonltd:update_following_startupmode_suppor_change_in_the_spec
Oct 19, 2023
Merged
Update following change in the support for the StartUpMode attribute for the RVC device type #29862
mergify
merged 3 commits into
project-chip:master
from
dysonltd:update_following_startupmode_suppor_change_in_the_spec
Oct 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
October 19, 2023 14:20
pullapprove
bot
requested review from
mspang,
nivi-apple,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
October 19, 2023 14:20
PR #29862: Size comparison from 7be98b1 to 138f01a Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Oct 19, 2023
plauric
approved these changes
Oct 19, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…for the RVC device type (project-chip#29862) * Removed the StartUpMode attribute from the RVC ModeBase clusters in chef's RVC device. * Reverted the changes made in PR 29248 following the spec change in PR 7576. * Restyled by prettier-markdown --------- Co-authored-by: Restyled.io <[email protected]>
shripad621git
pushed a commit
to shripad621git/connectedhomeip
that referenced
this pull request
Oct 31, 2023
…for the RVC device type (project-chip#29862) * Removed the StartUpMode attribute from the RVC ModeBase clusters in chef's RVC device. * Reverted the changes made in PR 29248 following the spec change in PR 7576. * Restyled by prettier-markdown --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the SDK following the spec change in PR7576 that saw the
StartUpMode
attribute of theRvcRunMode
andRvcCleanMode
clusters marked with conformancex
for the RVC device type.The changes made to the SDK are
StartUpMode
attribute in theRvcCleanMode
cluster for the RVC example app.