-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decrease dependency on WeakEnum
: GeneralDiagnostics::RadioFaultEnum, InterfaceTypeEnum
#29694
Merged
mergify
merged 11 commits into
project-chip:master
from
andy31415:remove_weak_radio_fault_enum
Oct 11, 2023
Merged
Decrease dependency on WeakEnum
: GeneralDiagnostics::RadioFaultEnum, InterfaceTypeEnum
#29694
mergify
merged 11 commits into
project-chip:master
from
andy31415:remove_weak_radio_fault_enum
Oct 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple and
lazarkov
October 10, 2023 19:16
PR #29694: Size comparison from 6deee69 to 10ef779 Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (17 builds for cc13x4_26x4, cc32xx, k32w, mbed, nrfconnect, qpg)
|
andy31415
changed the title
Decrease dependency on
Decrease dependency on Oct 10, 2023
WeakEnum
: GeneralDiagnostics::RadioFaultEnumWeakEnum
: GeneralDiagnostics::RadioFaultEnum, InterfaceTypeEnum
PR #29694: Size comparison from 6deee69 to 0b63416 Increases (8 builds for cc32xx, k32w, linux, qpg)
Decreases (1 build for cc32xx)
Full report (11 builds for cc32xx, k32w, linux, mbed, qpg)
|
PR #29694: Size comparison from 6deee69 to 63d3291 Increases above 0.2%:
Increases (74 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (13 builds for bl702, bl702l, cc32xx, linux, psoc6)
Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Oct 11, 2023
pidarped
approved these changes
Oct 11, 2023
cecille
approved these changes
Oct 11, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…, InterfaceTypeEnum (project-chip#29694) * First update for radio fault enum * Fix compile (I hope) * Fix compilation again * Fix BLE constant as well * Undo submodule update * Remove InterfaceTypeEnum from the list of weak enums * Replace all scoped constants with new names * Also convert all InterfaceTypeEnum calls * Fix compilation * Fix boufallolab build * Better namespace names for all other platforms (fix compile) --------- Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed RadioFaultEnum from WeakEnum list.
Updated code to make it compile. Tested linux all-clusters, light and qpg light (for platform code). Assuming all the rest are ok since updated via scripts. CI should catch any other errors.