-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation for kotlin-matter-controller #29636
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
October 6, 2023 18:28
pullapprove
bot
requested review from
turon,
vivien-apple,
wiba-nordic,
woody-apple and
younghak-hwang
October 6, 2023 18:28
PR #29636: Size comparison from c73199d to 58a7e7a Decreases (1 build for bl602)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Oct 6, 2023
PR #29636: Size comparison from 43981ac to ea98f2d Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Oct 10, 2023
examples/kotlin-matter-controller/java/src/com/matter/controller/Main.kt
Outdated
Show resolved
Hide resolved
andy31415
reviewed
Oct 10, 2023
examples/kotlin-matter-controller/java/src/com/matter/controller/Main.kt
Show resolved
Hide resolved
andy31415
reviewed
Oct 10, 2023
examples/kotlin-matter-controller/java/src/com/matter/controller/commands/common/Argument.kt
Show resolved
Hide resolved
andy31415
reviewed
Oct 10, 2023
...ples/kotlin-matter-controller/java/src/com/matter/controller/commands/common/FutureResult.kt
Outdated
Show resolved
Hide resolved
andy31415
reviewed
Oct 10, 2023
...ples/kotlin-matter-controller/java/src/com/matter/controller/commands/common/FutureResult.kt
Outdated
Show resolved
Hide resolved
andy31415
reviewed
Oct 10, 2023
...ples/kotlin-matter-controller/java/src/com/matter/controller/commands/common/FutureResult.kt
Show resolved
Hide resolved
andy31415
reviewed
Oct 10, 2023
...ples/kotlin-matter-controller/java/src/com/matter/controller/commands/common/FutureResult.kt
Outdated
Show resolved
Hide resolved
andy31415
reviewed
Oct 10, 2023
examples/kotlin-matter-controller/java/src/com/matter/controller/commands/common/IPAddress.kt
Outdated
Show resolved
Hide resolved
andy31415
reviewed
Oct 10, 2023
examples/kotlin-matter-controller/java/src/com/matter/controller/commands/common/RealResult.kt
Outdated
Show resolved
Hide resolved
andy31415
reviewed
Oct 10, 2023
...ntroller/java/src/com/matter/controller/commands/pairing/PairOnNetworkLongImInvokeCommand.kt
Outdated
Show resolved
Hide resolved
andy31415
reviewed
Oct 10, 2023
examples/kotlin-matter-controller/java/src/com/matter/controller/commands/common/IPAddress.kt
Outdated
Show resolved
Hide resolved
…ining time or until it's notified
PR #29636: Size comparison from 6deee69 to f6f1191 Increases (2 builds for bl702, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Oct 11, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Initial implementaton for kotlin-matter-controller * Address review comments * Use lock.wait(remainingTime) to allow the thread to wait for the remaining time or until it's notified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
examples
fast track
review - pending
scripts
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of kotlin-matter-controller which is used to test Kotlin API, this app will be integrated into CI in a separate PR.
The initial version is based on java-matter-controller, following tickets are registered to follow up future improvements, apply to both example apps
#29629
#29630
#29631
#29632
#29633
#29634
#29635
#29688