-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android]Initial implementation of Kotlin Matter Controller #29574
Merged
yufengwangca
merged 5 commits into
project-chip:master
from
yufengwangca:pr/kotlin/controller
Oct 6, 2023
Merged
[Android]Initial implementation of Kotlin Matter Controller #29574
yufengwangca
merged 5 commits into
project-chip:master
from
yufengwangca:pr/kotlin/controller
Oct 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
October 5, 2023 01:28
PR #29574: Size comparison from 883f03e to fb390c3 Full report (54 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
andy31415
reviewed
Oct 5, 2023
src/controller/java/src/matter/controller/MatterControllerImpl.kt
Outdated
Show resolved
Hide resolved
andy31415
reviewed
Oct 5, 2023
andy31415
reviewed
Oct 5, 2023
andy31415
reviewed
Oct 5, 2023
andy31415
reviewed
Oct 5, 2023
andy31415
reviewed
Oct 5, 2023
andy31415
reviewed
Oct 5, 2023
andy31415
reviewed
Oct 5, 2023
andy31415
reviewed
Oct 5, 2023
andy31415
reviewed
Oct 5, 2023
andy31415
reviewed
Oct 5, 2023
andy31415
reviewed
Oct 5, 2023
andy31415
reviewed
Oct 5, 2023
andy31415
approved these changes
Oct 5, 2023
PR #29574: Size comparison from 883f03e to c8a10c4 Increases (7 builds for cc13x4_26x4, efr32, nrfconnect, psoc6)
Decreases (10 builds for bl702, linux, nrfconnect)
Full report (54 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
joonhaengHeo
approved these changes
Oct 6, 2023
PR #29574: Size comparison from ccdbfee to fdd2bca Increases (1 build for telink)
Decreases (1 build for telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…chip#29574) * Initial implemenation of Kotlin Matter Controller * Rename to KotlinMatterController * Rename Interactions to InteractionClient * Address review comments * Restyled by gn --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Matter SDK Java API currently employs a mixture of technologies. Specifically, three libraries (tlv, jsontlv, onboardingpayload) are written in Kotlin, whereas devicecontroller is implemented in Java.
Implement core Interaction Model APIs in Kotlin, serving as the foundation upon which other APIs can be built.
Integrate seamlessly with existing Kotlin libraries to create a complete suite of Kotlin APIs.
Minimize interaction with native layers by utilizing a set of Core APIs, build everything else including the generated cluster APIs on top of it, resulting in an extremely lightweight JNI implementation.
A testing app kotlin-matter-controller together with the integration tests and CI integration will be posted in separate PRs.