-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement MTRBaseCluster invokes on top of MTRBaseDevice. #29554
Merged
mergify
merged 3 commits into
project-chip:master
from
bzbarsky-apple:nix-command-bridging
Oct 4, 2023
Merged
Implement MTRBaseCluster invokes on top of MTRBaseDevice. #29554
mergify
merged 3 commits into
project-chip:master
from
bzbarsky-apple:nix-command-bridging
Oct 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gets rid of command bridge code and shares code a lot better.
bzbarsky-apple
force-pushed
the
nix-command-bridging
branch
from
October 3, 2023 22:48
e3701e6
to
66894b7
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
October 3, 2023 22:48
pullapprove
bot
requested review from
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
October 3, 2023 22:48
woody-apple
approved these changes
Oct 3, 2023
PR #29554: Size comparison from 68d69cb to 66894b7 Increases (1 build for telink)
Decreases (1 build for telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
ksperling-apple
approved these changes
Oct 4, 2023
Fast-tracking platform-specific change with platform owner review. |
PR #29554: Size comparison from 68d69cb to 40f2832 Full report (17 builds for cc13x4_26x4, cc32xx, k32w, mbed, nrfconnect, qpg)
|
PR #29554: Size comparison from 68d69cb to 48e18e2 Full report (27 builds for cc13x4_26x4, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
bzbarsky-apple
force-pushed
the
nix-command-bridging
branch
from
October 4, 2023 03:29
48e18e2
to
332a0a9
Compare
PR #29554: Size comparison from 68d69cb to 332a0a9 Increases (1 build for telink)
Decreases (2 builds for bl702, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…ip#29554) * Implement MTRBaseCluster invokes on top of MTRBaseDevice. This gets rid of command bridge code and shares code a lot better. * Address review comment. * Remove some more code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of command bridge code and shares code a lot better.