-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make MTRClusters just use MTRDevice for command invokes. #29541
Merged
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:implement-MTRClusters-on-MTRDevice
Oct 3, 2023
Merged
Make MTRClusters just use MTRDevice for command invokes. #29541
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:implement-MTRClusters-on-MTRDevice
Oct 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mhazley
October 3, 2023 06:40
pullapprove
bot
requested review from
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
October 3, 2023 06:40
PR #29541: Size comparison from 1ec98c8 to b074a31 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
implement-MTRClusters-on-MTRDevice
branch
from
October 3, 2023 14:48
b074a31
to
90a8292
Compare
PR #29541: Size comparison from 51f7c2e to 90a8292 Full report (1 build for cc32xx)
|
bzbarsky-apple
force-pushed
the
implement-MTRClusters-on-MTRDevice
branch
from
October 3, 2023 15:00
90a8292
to
8ba19fa
Compare
Decouples them from MTRBaseClusters.
bzbarsky-apple
force-pushed
the
implement-MTRClusters-on-MTRDevice
branch
from
October 3, 2023 15:03
8ba19fa
to
9b5dfbd
Compare
PR #29541: Size comparison from 1248c18 to 9b5dfbd Decreases (1 build for bl702)
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Oct 3, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…p#29541) Decouples them from MTRBaseClusters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decouples them from MTRBaseClusters.