-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix IPAddress Type mismatch between echo-requester and echo-responder. #29419
Conversation
7f94d83
to
678f5ed
Compare
678f5ed
to
08f8544
Compare
PR #29419: Size comparison from 59d2b7e to 08f8544 Increases (1 build for telink)
Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@pidarped please take a look at the cirque failure ... it may actually be sensitive to ipv4 vs ipv6 changes, so guessing it may be a real failure... |
you might need to update the test case in Cirque to only use ipv6 |
08f8544
to
37738e4
Compare
PR #29419: Size comparison from 568362a to 37738e4 Full report (17 builds for cc13x4_26x4, cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
37738e4
to
d062253
Compare
When using TCP, the echo-server was listening over IPv4 while the echo-requester was getting configured for IPv6. Normalize both sides to always use IPv6 over both TCP or MRP.
d062253
to
1f97460
Compare
PR #29419: Size comparison from 568362a to 1f97460 Increases (1 build for telink)
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@yufengwangca, @andy31415, the Cirque failure was, essentially, a pre-existing memory leak in the TCP test. The connection was created 'implicitly' when the first EchoRequest was sent, but it was not released. In its current form, the test app needs to explicitly call Disconnect() to release the Connection TCPEndPoint at the end. |
project-chip#29419) When using TCP, the echo-server was listening over IPv4 while the echo-requester was getting configured for IPv6. Normalize both sides to always use IPv6 over both TCP or MRP.
When using TCP, the echo-server was listening over IPv4 while the echo-requester was getting configured for IPv6.
Normalize both sides to always use IPv6 over both TCP or MRP.