-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time sync: Remove ClusterStateCache #29396
Merged
mergify
merged 6 commits into
project-chip:master
from
cecille:remove_cluster_state_cache
Sep 26, 2023
Merged
Time sync: Remove ClusterStateCache #29396
mergify
merged 6 commits into
project-chip:master
from
cecille:remove_cluster_state_cache
Sep 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's easy to use, but it sure is big. Since we aren't asking for lists or anything, it's also overkill.
PR #29396: Size comparison from 02b8027 to b556807 Increases (8 builds for cyw30739, esp32, linux, nrfconnect, psoc6)
Decreases (9 builds for bl602, cyw30739, esp32, linux, nrfconnect, psoc6)
Full report (49 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
bzbarsky-apple
approved these changes
Sep 21, 2023
src/app/clusters/time-synchronization-server/time-synchronization-server.h
Outdated
Show resolved
Hide resolved
PR #29396: Size comparison from 02b8027 to e1a1150 Decreases (8 builds for cyw30739, esp32, linux, nrfconnect, psoc6)
Full report (49 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
pullapprove
bot
requested review from
andy31415,
arkq,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
kkasperczyk-no,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mhazley
September 22, 2023 00:26
pullapprove
bot
requested review from
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
younghak-hwang and
yufengwangca
September 22, 2023 00:27
andy31415
approved these changes
Sep 22, 2023
PR #29396: Size comparison from 02b8027 to a281e31 Increases above 0.2%:
Increases (9 builds for bl602, bl702, bl702l, nrfconnect, psoc6)
Decreases (13 builds for bl702, bl702l, cyw30739, esp32, linux, nrfconnect, psoc6)
Full report (49 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
bzbarsky-apple
approved these changes
Sep 23, 2023
src/app/clusters/time-synchronization-server/time-synchronization-delegate.h
Outdated
Show resolved
Hide resolved
src/app/clusters/time-synchronization-server/time-synchronization-delegate.h
Outdated
Show resolved
Hide resolved
Co-authored-by: Boris Zbarsky <[email protected]>
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Time sync: Remove ClusterStateCache It's easy to use, but it sure is big. Since we aren't asking for lists or anything, it's also overkill. * pack all the things into a class. * Fiddle with the build file * Comments on the delegate. * remove one more app prefix * Apply suggestions from code review Co-authored-by: Boris Zbarsky <[email protected]> --------- Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's handy, but oh so big.
Fixes: #28930