-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bouffalolab] Improve factory reset to make sure all configuration erased #29367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wy-hh
changed the title
[Bouffalolab] Improve the factory reset to make sure all configuration erased
[Bouffalolab] Improve factory reset to make sure all configuration erased
Sep 21, 2023
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kkasperczyk-no
September 21, 2023 09:27
pullapprove
bot
requested review from
mkardous-silabs,
mlepage-google,
mrjerryjohns,
nivi-apple,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang and
yunhanw-google
September 21, 2023 09:27
PR #29367: Size comparison from bfa9b4c to 167773f Increases above 0.2%:
Increases (8 builds for bl602, bl702, bl702l, telink)
Decreases (1 build for telink)
Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Sep 21, 2023
andy31415
approved these changes
Sep 22, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…ased (project-chip#29367) * do factory reset during startup if pending flag set * fix restyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factory reset will erase several flash sectors (at lease 8 sectors) of PSM region. If power-off happens during factory reset, there are some sectors will not be erased and some configurations left for next startup.
Now change to
kBLKey_factoryResetFlag
in flash, and then do reset if factory reset is triggered.kBLKey_factoryResetFlag
is existed in flash during startup, dokBLKey_factoryResetFlag
. Just in case, power-off happens here.kBLKey_factoryResetFlag
.