-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ZAP to pull in MTR_AVAILABLE. #29362
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzbarsky-apple
force-pushed
the
update-zap
branch
from
September 21, 2023 03:35
e6d7df0
to
5f5c433
Compare
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple and
lazarkov
September 21, 2023 03:35
pullapprove
bot
requested review from
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang and
yufengwangca
September 21, 2023 03:35
ksperling-apple
approved these changes
Sep 21, 2023
PR #29362: Size comparison from bfa9b4c to 5f5c433 Full report (4 builds for cc32xx, mbed, qpg)
|
PR #29362: Size comparison from bfa9b4c to 8b82065 Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Fast-tracking platform-specific fix with platform owner review. |
andy31415
approved these changes
Sep 22, 2023
bzbarsky-apple
force-pushed
the
update-zap
branch
2 times, most recently
from
September 23, 2023 02:28
d809587
to
2213288
Compare
PR #29362: Size comparison from a38af8b to 2213288 Decreases (1 build for bl702)
Full report (49 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
Also defines MTR_AVAILABLE to be empty if MTR_SKIP_AVAILABILITY_ANNOTATIONS is set, sets it in our CI, and removes all the -Wno-unguarded-availability-new. This caused use of "compare:" on UUIDs, which is not available until Mac OS 12.0, hence the update of deployment target to Mac OS 12.0.
bzbarsky-apple
force-pushed
the
update-zap
branch
from
September 23, 2023 04:05
2213288
to
11fe20d
Compare
PR #29362: Size comparison from a38af8b to 11fe20d Increases (1 build for telink)
Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Update ZAP to pull in MTR_AVAILABLE. Also defines MTR_AVAILABLE to be empty if MTR_SKIP_AVAILABILITY_ANNOTATIONS is set, sets it in our CI, and removes all the -Wno-unguarded-availability-new. This caused use of "compare:" on UUIDs, which is not available until Mac OS 12.0, hence the update of deployment target to Mac OS 12.0. * Address review comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also defines MTR_AVAILABLE to be empty if MTR_SKIP_AVAILABILITY_ANNOTATIONS is set, sets it in our CI, and removes all the -Wno-unguarded-availability-new.
This caused use of "compare:" on UUIDs, which is not available until Mac OS 12.0, hence the update of deployment target to Mac OS 12.0.
Note: The actual ZAP update is not available yet (waiting for project-chip/zap#1146), so this will not pass ZAP CI yet.