-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Fix handling manual code in CHIPTool #29255
[Android] Fix handling manual code in CHIPTool #29255
Conversation
PR #29255: Size comparison from 52caffd to 86b66ba Decreases (1 build for efr32)
Full report (49 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #29255: Size comparison from 2ce5864 to 4ee1e6a Decreases (2 builds for efr32, telink)
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM
@pachuho could you run kotlin formater on this? The CI presubmit cheker complains that the file is not formatted. |
...d/CHIPTool/app/src/main/java/com/google/chip/chiptool/setuppayloadscanner/BarcodeFragment.kt
Outdated
Show resolved
Hide resolved
…ature/fix_manual_code # Conflicts: # examples/android/CHIPTool/app/src/main/java/com/google/chip/chiptool/setuppayloadscanner/BarcodeFragment.kt
@pachuho your formatter somehow is different. I re-ran I believe this should merge now. |
* [Android] Fix handling manual code in CHIPTool * [Android] Fix handling manual code in CHIPTool * Re-run kotlin formatter via scriptsd/helpers/kotlin-format.sh --------- Co-authored-by: Andrei Litvin <[email protected]>
Fixes #29254
Problem
crash happens when click submit button in BarcodeFragment
Change summary
Modified the handleInputQrCode called when manualCodeBtn is clicked.
Previously, when OnboardingPayloadException occurred, the parseManualPairingCode was called. But in that commit
The string of the code was identified and processed to call the parseQrCode or parseManualPairingCode.
Testing
Tested the fix with the android by following the repro steps in the issue cited above.