-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Feature Map to ConcentrationMeasurement
Read Handler
#29098
Merged
mergify
merged 1 commit into
project-chip:master
from
dysonltd:concentration-measurement-add-feature-map-to-read-handler
Sep 7, 2023
Merged
Added Feature Map to ConcentrationMeasurement
Read Handler
#29098
mergify
merged 1 commit into
project-chip:master
from
dysonltd:concentration-measurement-add-feature-map-to-read-handler
Sep 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple and
lazarkov
September 6, 2023 16:47
pullapprove
bot
requested review from
robszewczyk,
younghak-hwang,
saurabhst,
yufengwangca,
selissia,
yunhanw-google,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple and
woody-apple
September 6, 2023 16:48
p0fi
approved these changes
Sep 6, 2023
tobiasgraf
approved these changes
Sep 6, 2023
tcarmelveilleux
approved these changes
Sep 6, 2023
src/app/clusters/concentration-measurement-server/concentration-measurement-server.h
Show resolved
Hide resolved
PR #29098: Size comparison from 741210d to 4ed7ea1 Increases (7 builds for linux, nrfconnect, psoc6, telink)
Decreases (2 builds for efr32, telink)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Sep 12, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
mFeatureMap
value that is generated from the class template args was not included in the Read Handler for this class.This was not picked up in CI as the
all-clusters-app
zapfile was set to the correct value and as such, this was getting returned when the Read Handler failed to encode anything.