-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch lwIP to git submodule, update it. #29056
Conversation
068480a
to
7640a43
Compare
PR #29056: Size comparison from 54038c0 to 7640a43 Increases above 0.2%:
Increases (6 builds for cc13x4_26x4, telink)
Decreases (1 build for efr32)
Full report (59 builds for cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
5a84783
to
cea5254
Compare
PR #29056: Size comparison from e29cd6a to cea5254 Increases above 0.2%:
Increases (6 builds for cc13x4_26x4, telink)
Decreases (1 build for efr32)
Full report (57 builds for cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
cea5254
to
e320239
Compare
PR #29056: Size comparison from 242a52b to c9a2d5c Increases above 0.2%:
Increases (7 builds for cc13x4_26x4, cc32xx, telink)
Full report (58 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
c9a2d5c
to
eade99f
Compare
eade99f
to
6acc4de
Compare
PR #29056: Size comparison from 6394d3e to 8ba80f4 Increases above 0.2%:
Increases (12 builds for bl702, bl702l, cc13x4_26x4, cc32xx)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
8ba80f4
to
7eebf73
Compare
PR #29056: Size comparison from d7c7f8e to 7eebf73 Increases above 0.2%:
Increases (2 builds for cc32xx)
Full report (8 builds for cc32xx, mbed, nrfconnect, qpg)
|
PR #29056: Size comparison from d7c7f8e to 226f741 Increases above 0.2%:
Increases (7 builds for cc13x4_26x4, cc32xx)
Full report (38 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, k32w, mbed, nrfconnect, psoc6, qpg)
|
PR #29056: Size comparison from d7c7f8e to bced734 Increases above 0.2%:
Increases (38 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, k32w, mbed, nrfconnect, psoc6, qpg)
Decreases (8 builds for esp32, nrfconnect, psoc6)
Full report (38 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, k32w, mbed, nrfconnect, psoc6, qpg)
|
Signed-off-by: Alexander Mazuruk <[email protected]>
Checked out to lastest release as it includes fix applied in Matter repository as well as some stuff referred to in repository issues. PBUF_POOL_BUFSIZE does not use sizeof anymore (it is used in one if in the lwip upstream code). Additionally removed turning off sanity checks that were necessary due to aforementioned sizeof usage. Added LwIPLog to Bouffalolab Logging as I couldnt find it defined anywhere for this platform. Signed-off-by: Alexander Mazuruk <[email protected]>
Signed-off-by: Alexander Mazuruk <[email protected]>
bced734
to
e7f8377
Compare
PR #29056: Size comparison from a3c5d19 to e7f8377 Increases above 0.2%:
Increases (2 builds for cc32xx)
Full report (8 builds for cc32xx, mbed, nrfconnect, qpg)
|
Signed-off-by: Alexander Mazuruk <[email protected]>
e7f8377
to
b81ff05
Compare
PR #29056: Size comparison from a3c5d19 to b81ff05 Increases above 0.2%:
Increases (7 builds for cc13x4_26x4, cc32xx)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
PR #29056: Size comparison from 18bcd0c to bfda100 Increases above 0.2%:
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #29056: Size comparison from 49db415 to aedc1df Increases above 0.2%:
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
There were few things that connectedhomeip and lwIP upstream differ on:
New LWIP didn't like sizeof in the PBUF_POOL_BUFSIZE so it was changed to use SIZEOF_POINTER and a static assert was added that checks if it is consistent with previous sizeof. According to comments LWIP_DISABLE_TCP_SANITY_CHECKS (1) was there only due to aforementioned sizeof thus it was removed.
Cleaned up lwIPs gni file and added support for additional netifs