-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manually remove client commant from server side #28890
Merged
andy31415
merged 1 commit into
project-chip:master
from
andy31415:fix_client_side_command_on_server
Aug 25, 2023
Merged
Manually remove client commant from server side #28890
andy31415
merged 1 commit into
project-chip:master
from
andy31415:fix_client_side_command_on_server
Aug 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mhazley
August 25, 2023 14:04
pullapprove
bot
requested review from
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
August 25, 2023 14:05
cecille
approved these changes
Aug 25, 2023
brdandu
reviewed
Aug 25, 2023
PR #28890: Size comparison from cac5620 to 9495f59 Decreases (1 build for efr32)
Full report (62 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Aug 25, 2023
jrhees-cae
approved these changes
Aug 25, 2023
tcarmelveilleux
approved these changes
Aug 25, 2023
saurabhst
approved these changes
Aug 25, 2023
bzbarsky-apple
approved these changes
Aug 25, 2023
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 25, 2023
Co-authored-by: Andrei Litvin <[email protected]>
This was referenced Aug 30, 2023
cecille
added a commit
to cecille/connectedhomeip
that referenced
this pull request
Oct 4, 2023
As in project-chip#28890 this zap had a client side command on the server that was causing a duplicate in the generated command list.
mergify bot
pushed a commit
that referenced
this pull request
Oct 4, 2023
As in #28890 this zap had a client side command on the server that was causing a duplicate in the generated command list.
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
Co-authored-by: Andrei Litvin <[email protected]>
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
As in project-chip#28890 this zap had a client side command on the server that was causing a duplicate in the generated command list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow the server side of a cluster reported a client-side command, resulting in duplicate "accepted commands" and overall not being valid.
Unclear how this happens - I would expect UI to not allow such a thing. For now manual edit.
Fixes #28859