-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SMOKECO SDK #28751
Merged
mergify
merged 11 commits into
project-chip:master
from
ericzijian1994:update-smokeco-sdk
Aug 22, 2023
Merged
Update SMOKECO SDK #28751
mergify
merged 11 commits into
project-chip:master
from
ericzijian1994:update-smokeco-sdk
Aug 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replace "if success" with "VerifyOrReturn" * Move SetExpressedState to private * Change unused bool to void
This reverts commit 89bdf78.
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs and
jmartinez-silabs
August 18, 2023 10:23
pullapprove
bot
requested review from
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
August 18, 2023 10:23
PR #28751: Size comparison from a40963d to 4fab58a Increases (7 builds for bl602, bl702, linux, psoc6)
Decreases (10 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6)
Full report (42 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
jmartinez-silabs
approved these changes
Aug 18, 2023
mkardous-silabs
approved these changes
Aug 18, 2023
PR #28751: Size comparison from a40963d to 28a5243 Increases above 0.2%:
Increases (24 builds for bl602, bl702, bl702l, cc32xx, efr32, esp32, linux, mbed, nrfconnect, psoc6, telink)
Decreases (18 builds for bl702, bl702l, efr32, esp32, linux, nrfconnect, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #28751: Size comparison from 270d8e2 to 2519e16 Increases (11 builds for bl602, cc32xx, cyw30739, linux, nrfconnect, psoc6, telink)
Decreases (18 builds for bl702, bl702l, efr32, esp32, linux, nrfconnect, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@jmartinez-silabs @mkardous-silabs |
s07641069
approved these changes
Aug 22, 2023
tima-q
approved these changes
Aug 22, 2023
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 25, 2023
* Update SMOKECO server * Replace "if success" with "VerifyOrReturn" * Move SetExpressedState to private * Change unused bool to void * Adapt all-cluster-app to server changes * Adapt telink smokeco to server changes * Add RequestSelfTest public function * Add smokeco long press command to all-cluster-app * Adapt smokeco example to server changes * Revert "Add RequestSelfTest public function" This reverts commit 89bdf78. * Add RequestSelfTest public function * Add LockChipStack * Adapt telink example to server changes --------- Co-authored-by: Hare <[email protected]>
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Update SMOKECO server * Replace "if success" with "VerifyOrReturn" * Move SetExpressedState to private * Change unused bool to void * Adapt all-cluster-app to server changes * Adapt telink smokeco to server changes * Add RequestSelfTest public function * Add smokeco long press command to all-cluster-app * Adapt smokeco example to server changes * Revert "Add RequestSelfTest public function" This reverts commit 89bdf78. * Add RequestSelfTest public function * Add LockChipStack * Adapt telink example to server changes --------- Co-authored-by: Hare <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The server and examples can be improved thanks to the previous additions to all-cluster-app.