-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding interface to handle manual step execution. #28741
Merged
mergify
merged 1 commit into
project-chip:master
from
gladystonfranca:add_manual_step_to_runner_interface
Aug 24, 2023
Merged
Adding interface to handle manual step execution. #28741
mergify
merged 1 commit into
project-chip:master
from
gladystonfranca:add_manual_step_to_runner_interface
Aug 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #28741: Size comparison from a40963d to b25eecc Increases (1 build for cc32xx)
Full report (2 builds for cc32xx, mbed)
|
gladystonfranca
force-pushed
the
add_manual_step_to_runner_interface
branch
from
August 17, 2023 23:02
b25eecc
to
1ec9e22
Compare
PR #28741: Size comparison from a40963d to 1ec9e22 Decreases (1 build for cc32xx)
Full report (4 builds for cc32xx, mbed, qpg)
|
Manual step execution are meant to be executed outside runner domain. E.g Collecting user feedback through prompt.
gladystonfranca
force-pushed
the
add_manual_step_to_runner_interface
branch
from
August 17, 2023 23:27
1ec9e22
to
4f357c5
Compare
PR #28741: Size comparison from a40963d to 4f357c5 Increases (14 builds for bl602, bl702, psoc6, telink)
Decreases (9 builds for efr32, esp32, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
August 18, 2023 12:55
pullapprove
bot
requested review from
mhazley,
mkardous-silabs,
mlepage-google,
mrjerryjohns,
nivi-apple,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
August 18, 2023 12:55
rquidute
approved these changes
Aug 23, 2023
raju-apple
approved these changes
Aug 24, 2023
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 25, 2023
Manual step execution are meant to be executed outside runner domain. E.g Collecting user feedback through prompt.
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
Manual step execution are meant to be executed outside runner domain. E.g Collecting user feedback through prompt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual step execution are meant to be executed outside runner domain.
E.g Collecting user feedback through prompt.
The goal of this change is to provide support for executing semi-automated tests as well as simulated tests that still needs user interaction (manual command execution)
The step result depends only on the user response ( Based on the prompt options).
PASS
FAIL
NOT APPLICABLE
Related Issue in TH
CHIP-Specifications/chip-certification-tool#884
General Discussion
Is there a policy related to plugin versioning?
Changes in interface shouldn't increase plugin version?
The change related to this PR is already in place as a patch on TestHarness.