-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Resource Monitoring to Separate out The Delegate functionality #28725
Merged
mergify
merged 24 commits into
project-chip:master
from
tobiasgraf:resource_monitoring_use_delegates
Aug 31, 2023
Merged
Refactor Resource Monitoring to Separate out The Delegate functionality #28725
mergify
merged 24 commits into
project-chip:master
from
tobiasgraf:resource_monitoring_use_delegates
Aug 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the Mode Base Cluster, to make it more similar.
also adjust include paths and BUILD.gn paths
# Conflicts: # examples/all-clusters-app/linux/BUILD.gn
PR #28725: Size comparison from d0da504 to 075100c Increases (1 build for cc32xx)
Full report (4 builds for cc32xx, mbed, qpg)
|
PR #28725: Size comparison from d0da504 to b78e85b Increases (2 builds for psoc6)
Decreases (7 builds for bl602, bl702, bl702l, psoc6)
Full report (22 builds for bl602, bl702, bl702l, cc32xx, cyw30739, k32w, linux, mbed, psoc6, qpg)
|
PR #28725: Size comparison from d0da504 to 7c8eb5c Increases (6 builds for linux, nrfconnect, psoc6)
Decreases (13 builds for bl602, bl702, bl702l, efr32, linux, nrfconnect, psoc6)
Full report (53 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
needs to unregister Command Handler and Attribute Accesser
PR #28725: Size comparison from d0da504 to b289f4a Increases (9 builds for linux, nrfconnect, psoc6, telink)
Decreases (21 builds for bl602, bl702, bl702l, cc32xx, efr32, linux, nrfconnect, psoc6, telink)
Full report (71 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
hicklin
reviewed
Aug 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have only reviewed the SDK server code so far.
src/app/clusters/resource-monitoring-server/resource-monitoring-server.h
Outdated
Show resolved
Hide resolved
src/app/clusters/resource-monitoring-server/resource-monitoring-server.h
Outdated
Show resolved
Hide resolved
src/app/clusters/resource-monitoring-server/resource-monitoring-server.h
Outdated
Show resolved
Hide resolved
src/app/clusters/resource-monitoring-server/resource-monitoring-server.cpp
Show resolved
Hide resolved
it should be the SDK user's responsibility to select the correct cluster ID and that it also requires the maintenance of a global list.
…_use_delegates # Conflicts: # examples/all-clusters-app/nrfconnect/CMakeLists.txt
-> make mInstance private with private setter and protected getter
pullapprove
bot
requested review from
mlepage-google,
mrjerryjohns,
mspang,
nivi-apple,
p0fi,
plauric,
rcasallas-silabs,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
turon,
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
August 30, 2023 07:38
bzbarsky-apple
approved these changes
Aug 30, 2023
hicklin
approved these changes
Aug 31, 2023
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Sep 12, 2023
…ty (project-chip#28725) * Move Constructors And Destructors To The Top Of The Instance * Add Delegate Instead Of Just The Instance Following the Mode Base Cluster, to make it more similar. * Use New Delegate In Resource-Monitoring-App Example * Rename "instances" Folder to "delegates" also adjust include paths and BUILD.gn paths * Use New Resource Monitoring Delegate In All-Cluster-App Example * Fix Typo * Rename "resource-monitoring-instances.h/cpp" To "resource-monitoring-delegates.h/cpp" * Add Shutdown Methods For All-Cluster-App * Fix Some Comments And Logs * Restyled by whitespace * Restyled by clang-format * Fix Build Error From Merge * Fix Build Error * Add Missing Destructor needs to unregister Command Handler and Attribute Accesser * Restyled by whitespace * Restyled by clang-format * Fix Spelling * Remove `isValidAliascluster` method it should be the SDK user's responsibility to select the correct cluster ID and that it also requires the maintenance of a global list. * Make Instance A Friend Of Delegate -> make mInstance private with private setter and protected getter * Restyled by whitespace * Restyled by clang-format * Fix Build Error --------- Co-authored-by: Restyled.io <[email protected]>
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…ty (project-chip#28725) * Move Constructors And Destructors To The Top Of The Instance * Add Delegate Instead Of Just The Instance Following the Mode Base Cluster, to make it more similar. * Use New Delegate In Resource-Monitoring-App Example * Rename "instances" Folder to "delegates" also adjust include paths and BUILD.gn paths * Use New Resource Monitoring Delegate In All-Cluster-App Example * Fix Typo * Rename "resource-monitoring-instances.h/cpp" To "resource-monitoring-delegates.h/cpp" * Add Shutdown Methods For All-Cluster-App * Fix Some Comments And Logs * Restyled by whitespace * Restyled by clang-format * Fix Build Error From Merge * Fix Build Error * Add Missing Destructor needs to unregister Command Handler and Attribute Accesser * Restyled by whitespace * Restyled by clang-format * Fix Spelling * Remove `isValidAliascluster` method it should be the SDK user's responsibility to select the correct cluster ID and that it also requires the maintenance of a global list. * Make Instance A Friend Of Delegate -> make mInstance private with private setter and protected getter * Restyled by whitespace * Restyled by clang-format * Fix Build Error --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 Description
This PR refactors the resource monitoring server instances to seperate out the delegate functionality into it's own class.
This is also done to be some similar to the mode base cluster ( as it also uses the alias concept)
🧪 How Has This Been Tested
Test_TC_ACFREMON_1_1
,Test_TC_ACFREMON_2_1
,Test_TC_HEPAFREMON_1_1
andTest_TC_HEPAFREMON_2_1
against all-cluster-app and resource-monitoring-app