-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix warning Classes that contain only a companion object should be re… #28710
Merged
Damian-Nordic
merged 1 commit into
project-chip:master
from
yufengwangca:pr/kotlin/setup
Aug 17, 2023
Merged
Fix warning Classes that contain only a companion object should be re… #28710
Damian-Nordic
merged 1 commit into
project-chip:master
from
yufengwangca:pr/kotlin/setup
Aug 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #28710: Size comparison from 39511c2 to b842cc4 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
…placed with a named object declaration
PR #28710: Size comparison from 39511c2 to 2fd15ca Increases (12 builds for bl602, bl702l, cc32xx, telink)
Decreases (14 builds for bl602, bl702, efr32, k32w, nrfconnect, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no and
ksperling-apple
August 15, 2023 19:17
pullapprove
bot
requested review from
mhazley,
mkardous-silabs,
mlepage-google,
mrjerryjohns,
nivi-apple,
p0fi,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang and
yunhanw-google
August 15, 2023 19:17
yunhanw-google
approved these changes
Aug 16, 2023
Damian-Nordic
approved these changes
Aug 17, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…placed with a named object declaration (project-chip#28710)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…placed with a named object declaration
third_party/connectedhomeip/next/src/controller/java/src/chip/onboardingpayload/Verhoeff.kt:20: Error: Classes that contain only a companion object should be replaced with a named object declaration (see https://kotlinlang.org/docs/object-declarations.html#object-declarations-overview) [ClassShouldBeObject]