-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python script: start of TH integration code #28708
Python script: start of TH integration code #28708
Conversation
- adds required command line functionality (endpoint, nodeID, timeout) - adds the ability to pass in a hooks object for use by the TH - adds an internal hooks object when scripts are being used on the command line - adds hook calls as appropriate at test start / end / steps To setup a test for use in the TH, define a steps_ and desc_ function with the same name as the test, change print_step() calls to step() calls with the appropriate number, add pics_guard calls around pics checks. Changes the hello_test to demonstrate how to do this and also how the test works if the steps_ function is not defined. Added a demonstration of how the TH could call these to get the hooks back out.
PR #28708: Size comparison from 39511c2 to 628faa2 Increases (9 builds for bl602, bl702l, telink)
Decreases (8 builds for bl602, bl702, efr32, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should remove hello_external_runner.py and hello_test.py from this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some TODO in matter_testing_support.py
file, could you take a look on them?
PR #28708: Size comparison from 2675b00 to 92085b3 Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #28708: Size comparison from 2675b00 to bc0bacd Increases (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (2 builds for linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
fast track given the large amount of checkmarks and TH validation. |
To setup a test for use in the TH, define a steps_ and desc_ function with the same name as the test, change print_step() calls to step() calls with the appropriate number, add pics_guard calls around pics checks.
Changes the hello_test to demonstrate how to do this and also how the test works if the steps_ function is not defined.
Added a demonstration of how the TH could call these to get the hooks back out.